Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running with flag --enable-frozen-string-literal crashes stdlib/jar_dependencies.rb #3975

Closed
brometeo opened this issue Jun 22, 2016 · 5 comments
Closed
Milestone

Comments

@brometeo
Copy link

@brometeo brometeo commented Jun 22, 2016

Environment

JRuby version: 9.1.2.0

Expected Behavior

Work normally

Actual Behavior

It crashes because of jruby-9.1.2.0/lib/ruby/stdlib/jar_dependencies.rb line 356:
file = "#{group_id.gsub( '.', '/' )}/#{artifact_id}/#{version}/#{artifact_id}-#{version}"

It should be substituted by:
file = String.new("#{group_id.gsub( '.', '/' )}/#{artifact_id}/#{version}/#{artifact_id}-#{version}")

for creating a mutable String object.

@kares
Copy link
Member

@kares kares commented Jun 22, 2016

thanks, this is likely an issue of https://github.com/mkristian/jar-dependencies // cc @mkristian

@brometeo
Copy link
Author

@brometeo brometeo commented Jun 22, 2016

Thank you. I have written it in jar-dependencies page :)

@brometeo brometeo closed this Jun 22, 2016
@kares kares added this to the Invalid or Duplicate milestone Jun 22, 2016
@mkristian
Copy link
Member

@mkristian mkristian commented Aug 12, 2016

mkristian/jar-dependencies#48 as we might want to have this in the next release with fixed version of jar-dependencies

@headius
Copy link
Member

@headius headius commented Aug 12, 2016

@mkristian Can we get that done ASAP? We'd like to do 9.1.3.0 release some time next week.

@mkristian
Copy link
Member

@mkristian mkristian commented Aug 12, 2016

@headius will do it over the weekend

@mkristian mkristian closed this in 70fff62 Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.