Math.log10 should use Java's log10 method #4089

Closed
enebo opened this Issue Aug 18, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@enebo
Member

enebo commented Aug 18, 2016

jruby -e 'p Math.log10(1_000_000)'
5.999999999999999

because we use Java's generic log method. If I switch us to java.lang.Math.log10 when in base 10 we get the expected 6.

@enebo enebo added the core label Aug 18, 2016

@enebo enebo added this to the JRuby 9.1.3.0 milestone Aug 18, 2016

@enebo enebo referenced this issue in seattlerb/minitest Aug 18, 2016

Closed

Accept floating point inconsistencies in bench_exp #642

enebo added a commit that referenced this issue Aug 18, 2016

@enebo enebo closed this in 69b5767 Aug 18, 2016

@zenspider

This comment has been minimized.

Show comment
Hide comment
@zenspider

zenspider Aug 18, 2016

Fantastic. This! This is exactly why communication is gold.

Fantastic. This! This is exactly why communication is gold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment