Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math.log10 should use Java's log10 method #4089

Closed
enebo opened this issue Aug 18, 2016 · 1 comment
Closed

Math.log10 should use Java's log10 method #4089

enebo opened this issue Aug 18, 2016 · 1 comment
Labels
Milestone

Comments

@enebo
Copy link
Member

@enebo enebo commented Aug 18, 2016

jruby -e 'p Math.log10(1_000_000)'
5.999999999999999

because we use Java's generic log method. If I switch us to java.lang.Math.log10 when in base 10 we get the expected 6.

@zenspider
Copy link

@zenspider zenspider commented Aug 18, 2016

Fantastic. This! This is exactly why communication is gold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.