Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jruby-gradle plugin fails with a 9.1.3.0-SNAPSHOT #4114

Closed
robertpanzer opened this issue Aug 25, 2016 · 5 comments
Closed

jruby-gradle plugin fails with a 9.1.3.0-SNAPSHOT #4114

robertpanzer opened this issue Aug 25, 2016 · 5 comments
Milestone

Comments

@robertpanzer
Copy link

@robertpanzer robertpanzer commented Aug 25, 2016

Environment

JRuby 9.1.3.0-SNAPSHOT (999cea0)
MacOS and Windows
Java 1.8.0_91
Grade 2.14

Expected Behavior

The JRuby Gradle plugin should be able to install Ruby gems in the AsciidoctorJ build.

Actual Behavior

The build fails with this error:

:asciidoctorj:jrubyPrepare
[Fatal Error] erubis-2.7.0.pom:15:35: The content of elements must consist of well-formed character data or markup.
[Fatal Error] erubis-2.7.0.pom:15:35: The content of elements must consist of well-formed character data or markup.
Exception in thread "main" java.lang.NoClassDefFoundError: org/objectweb/asm/ClassVisitor
        at org.jruby.RubyInstanceConfig.<init>(RubyInstanceConfig.java:84)
        at org.jruby.Main.<init>(Main.java:101)
        at org.jruby.Main.main(Main.java:200)
Caused by: java.lang.ClassNotFoundException: org.objectweb.asm.ClassVisitor
        at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 3 more
:asciidoctorj:jrubyPrepare FAILED

It seems like the classes are missing in the 9.1.3.0-SNAPSHOT.
They are present in a jruby-core-9.1.2.0.jar but missing in jruby-core-9.1.3.0-SNAPSHOT.jar.

@mkristian
Copy link
Member

@mkristian mkristian commented Aug 25, 2016

@robertpanzer I am not sure how you built the SNAPSHOT, with mvn clean install -Pdist ? mvn clean install does not produce a release artifact ! mvn clean install -Pdist or mvn clean install -Pcomplete or some other profile is needed.

@robertpanzer
Copy link
Author

@robertpanzer robertpanzer commented Aug 25, 2016

I called ./mvnw -Pall $skipTests.
At least I got some artifacts installed in my local maven cache.
Did I miss some steps?

@mkristian
Copy link
Member

@mkristian mkristian commented Aug 25, 2016

@robertpanzer no you did not, all indeed does not build the release artifact for core :(

lemme fix this.

mkristian added a commit that referenced this issue Aug 25, 2016
…ct with all shaded jars

fixes #4114
@mkristian
Copy link
Member

@mkristian mkristian commented Aug 25, 2016

@robertpanzer I did not run your gradle example but manually tested the content of the jar.

@mkristian mkristian closed this Aug 25, 2016
@robertpanzer
Copy link
Author

@robertpanzer robertpanzer commented Aug 25, 2016

Thanks! Also retested!

@enebo enebo added this to the JRuby 9.1.3.0 milestone Aug 26, 2016
headius added a commit that referenced this issue Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.