Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Logger: log rotation inter-process lock failed. on Windows with JRuby 9.x #4147
Provide at least:
We test it in JRuby1.6.8, JRuby1.7.22 and Ruby 2.3.1,
And we find the source codes in jruby-188.8.131.52\lib\ruby\stdlib\logger.rb line 745
For Ruby, the value of RUBY_PLATFORM likes "x64-mingw32".
For test, we change
So, is this a JRuby bug?
@smk0621 Ahh yes, a platform check. I think the proper fix for this would be to modify the check to use RbConfig rather than RUBY_PLATFORM, probably something like this:
if /mswin|mingw/ =~ RbConfig::CONFIG['host_os']
This will work on all Ruby versions.
Wanna test this and put together a PR for us?
This is the sort of thing we're generally comfortable patching in our copy of MRI's stdlib, but we do usually try to get such changes upstreamed to MRI. We'll handle that at some point.