New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prime? openssl error in 9.1.5.0 #4193

Closed
jzakiya opened this Issue Sep 30, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@jzakiya

jzakiya commented Sep 30, 2016

Environment

$ jruby -v
jruby 9.1.5.0 (2.3.1) 2016-09-07 036ce39 Java HotSpot(TM) 64-Bit Server VM 25.102-b14 on 1.8.0_102-b14 +jit [linux-x86_64]

$ uname -a
Linux localhost 4.7.5-pclos1 #1 SMP Sun Sep 25 17:05:47 CDT 2016 x86_64 x86_64 x86_64 GNU/Linux

Expected Behavior

> require 'openssl'
> 5.to_bn.prime?
 => true
> -5.to_bn.prime?
 => false

Actual Behavior

> require 'openssl'
> 5.to_bn.prime?
 => true
> -5.to_bn.prime?     
 => true                  -- should be false, this is an error for all negative primes
@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Sep 30, 2016

Member

Seems legit. Normally I'd ask you to re-file at jruby/jruby-openssl but this seems pretty trivial.

Member

headius commented Sep 30, 2016

Seems legit. Normally I'd ask you to re-file at jruby/jruby-openssl but this seems pretty trivial.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Sep 30, 2016

Member

@kares @mkristian Any reason we couldn't put out a jruby-openssl release right now?

Member

headius commented Sep 30, 2016

@kares @mkristian Any reason we couldn't put out a jruby-openssl release right now?

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Sep 30, 2016

Member

This is fixed in jruby-openssl and just needs releases.

Member

headius commented Sep 30, 2016

This is fixed in jruby-openssl and just needs releases.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Sep 30, 2016

Member

Oh...we need tests for this. Want to PR something quick for jruby/jruby-openssl?

Member

headius commented Sep 30, 2016

Oh...we need tests for this. Want to PR something quick for jruby/jruby-openssl?

@headius headius added the needs tests label Sep 30, 2016

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Nov 10, 2016

Member

this actually isn't in 9.1.6.0 unless gem install jruby-openssl, updated gem (0.9.18) should be in 9.1.7.0

Member

kares commented Nov 10, 2016

this actually isn't in 9.1.6.0 unless gem install jruby-openssl, updated gem (0.9.18) should be in 9.1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment