/jruby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby 2.4] Add support for @ and $ in regexp named groups #4287

Closed
headius opened this Issue Nov 14, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  JRuby 9.2.0.0
2 participants
@headius @enebo
@headius
Member

headius commented Nov 14, 2016

See https://bugs.ruby-lang.org/issues/11949

I will be excluding at least one file on the ruby-2.4 branch that does not parse currently.

@headius headius added core ruby 2.4 labels Nov 14, 2016

@headius headius added this to the JRuby 9.2.0.0 milestone Nov 14, 2016

@headius

This comment has been minimized.

Sign in to view
Member

headius commented Nov 14, 2016

Ref #4293

headius added a commit that referenced this issue Nov 14, 2016

@headius
Exclude unparsable test_regexp.rb from MRI. #4287
a6385c4

headius added a commit to jruby/joni that referenced this issue Nov 17, 2016

@headius
Expand allowed names for named captures. 
See jruby/jruby#4287 and https://bugs.ruby-lang.org/issues/11949
aee0d27

headius added a commit that referenced this issue Nov 17, 2016

@headius
Update to joni that allows more named capture names. Fixes #4287.
Loading status checks…
3995a2d

@headius headius closed this Nov 17, 2016

@enebo enebo modified the milestones: JRuby 9.2.0.0, JRuby 9.1.9.0 Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment