Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby 2.4] Queue and other thread-sync classes moved under Thread #4292

Closed
headius opened this issue Nov 14, 2016 · 1 comment
Closed

[ruby 2.4] Queue and other thread-sync classes moved under Thread #4292

headius opened this issue Nov 14, 2016 · 1 comment

Comments

@headius
Copy link
Member

@headius headius commented Nov 14, 2016

See https://bugs.ruby-lang.org/issues/8919.

The various thread-synchronization classes like Queue and ConditionVariable now live under the Thread namespace. The top-level constants still exist, but until we move them we get warnings like this:

/Users/headius/projects/jruby/lib/ruby/stdlib/singleton.rb:136: warning: toplevel constant Mutex referenced by Thread::Mutex
/Users/headius/projects/jruby/lib/ruby/stdlib/digest.rb:6: warning: toplevel constant Mutex referenced by Thread::Mutex
/Users/headius/projects/jruby/lib/ruby/stdlib/monitor.rb:244: warning: toplevel constant Mutex referenced by Thread::Mutex
/Users/headius/projects/jruby/test/mri/monitor/test_monitor.rb:8: warning: toplevel constant Queue referenced by Thread::Queue
/Users/headius/projects/jruby/lib/ruby/stdlib/webrick/utils.rb:129: warning: toplevel constant Mutex referenced by Thread::Mutex
/Users/headius/projects/jruby/test/mri/thread/test_queue.rb:8: warning: toplevel constant Queue referenced by Thread::Queue
/Users/headius/projects/jruby/test/mri/thread/test_queue.rb:9: warning: toplevel constant SizedQueue referenced by Thread::SizedQueue
@headius headius added this to the JRuby 9.2.0.0 milestone Nov 14, 2016
@headius headius changed the title Queue and other thread-sync classes moved under Thread [ruby 2.4] Queue and other thread-sync classes moved under Thread Nov 14, 2016
@headius
Copy link
Member Author

@headius headius commented Nov 14, 2016

Ref #4293

headius added a commit that referenced this issue Nov 14, 2016
@headius headius closed this Nov 15, 2016
@enebo enebo modified the milestones: JRuby 9.2.0.0, JRuby 9.1.9.0 Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.