Ha! Fun thing... I just talked to @colszowka (creator of simplecov) a while back about JRuby support etc. and he asked if I'd be willing to join the team and be the JRuby support person and officially support JRuby. We both agreed that chances of this requiring any work/of any regressions would be super low 😄
Anyhow, the simplecov specs also fail on jruby-head now and it seems to be exactly the integration tests with different reported coverage values.
I can also confirm the decreased coverage on the repo @donv mentioned:
tobi@comfy ~/github/capybara-screenshot-diff $ GEM_HOME=vendor JRUBY_OPTS=--debug ../jruby/bin/jruby -S vendor/bin/bundle exec rake test
Started with run options --seed 61202
11/11: [=================================] 100% Time: 00:00:00, Time: 00:00:00
Finished in 0.77429s
11 tests, 25 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for Unit Tests to /home/tobi/github/capybara-screenshot-diff/coverage. 11333 / 26516 LOC (42.74%) covered.
Coverage (42.74%) is below the expected minimum coverage (86.00%).
Command failed with status (2)
#lots of complaining
@enebo there is a switch in the repo that checks if JRuby has --debug enabled and doesn't run them unless the switch is set --> with it it runs fine :)
Happy to help in any way to debug this and get it back working for 22.214.171.124 as this is a critical bug/regression for me personally :D
Anyhow, happy holidays to all of you and thanks for all you do 🌟
so JRuby must potentially dead-locks in a debugging session so that simplecov reports correct coverage ...
maybe there's a remedy of having simplecov improved or not - imagine it relies on an at_axit handler
at_exit seems to be used her - I'm not in the simplecov code base that much yet and time is somewhat limited, if you gave me general directions of what'd be the problem/potential fix I could try fixing that :)
also @enebo thanks for bisecting and all the work :) 💚
jruby 126.96.36.199-SNAPSHOT (2.3.1) 2016-12-21 946befd Java HotSpot(TM) 64-Bit Server VM 25.112-b16 on 1.8.0_112-b16 +jit [darwin-x86_64]
When testing https://travis-ci.org/donv/capybara-screenshot-diff I get a very low coverage percentage using simplecov and JRuby 188.8.131.52-SNAPSHOT.
I get the expected coverage percentage of 86% when using any MRI version since 2.1 and JRuby 184.108.40.206, 220.127.116.11, and 18.104.22.168.
The text was updated successfully, but these errors were encountered: