Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
This works in MRI 2.3.3 and 2.4.0, but fails on jruby-22.214.171.124:
sock = UNIXSocket.new("boom")
IOError: not opened for reading
from org/jruby/RubyIO.java:2992:in `read'
Travis failure (has all the jruby version info + platform info):
Test case: https://github.com/square/debug_socket/blob/a94f1c857b2626273eba9331dbc43d3d2ad0cf4e/spec/debug_socket_spec.rb#L29
The text was updated successfully, but these errors were encountered:
New failing spec: https://github.com/jruby/jruby/compare/master...nerdrew:nerdrew/close-write-spec?expand=1
Sorry, something went wrong.
Shut down the correct half when calling BasicSocket#close_write.
Weird...the code in jnr-unixsocket looks right, calling shutdown with read or write as appropriate. Must be in JRuby, perhaps not seeing that the other half is open and calling close to shut the whole thing down.
Remove redundant code. shutdownInternal should update flags.
See #4500 and #4503.
Thanks for the PR!
Shut down the correct half when calling BasicSocket#close_write
Successfully merging a pull request may close this issue.