New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plenty of [org.jruby.EvalType] (value [NONE]) in thread-locals #4529

Closed
kares opened this Issue Mar 14, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@kares
Member

kares commented Mar 14, 2017

Environment

Tomcat .war deployed with 9.1.7.0 (2.3.1) 2017-01-11 68056ae Java HotSpot(TM) 64-Bit Server VM 24.55-b03 on 1.7.0_55-b13 +jit [linux-x86_64]

Expected Behavior

if possible less (eagerly) thread-locals that are potentially unnecessary.
JRuby 1.7.x caused much less noise on re-deploy ...

Actual Behavior

3000 lines of thread-local warnings such as :

[2017-03-14 09:45:09,880] ERROR [vtscxzt70con1-startStop-2] {org.apache.catalina.loader.WebappClassLoader} The web application [/smb] created a ThreadLocal with key of type [java.lang.ThreadLocal] (value [java.lang.ThreadLocal@2a094bac]) and a value of type [org.jruby.EvalType] (value [NONE]) but failed to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.

there was already an attempt to resolve this at #4215 (which shipped with 9.1.7.0)

kares added a commit that referenced this issue Mar 14, 2017

kares added a commit that referenced this issue Mar 14, 2017

@kares kares added this to the JRuby 9.1.9.0 milestone Mar 14, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Mar 17, 2017

Member

Yeah I've never really liked this use of thread-locals. We should find a better way, like just having a field on ThreadContext.

Member

headius commented Mar 17, 2017

Yeah I've never really liked this use of thread-locals. We should find a better way, like just having a field on ThreadContext.

@kares kares closed this in #4530 Mar 18, 2017

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Mar 18, 2017

Member

sounds good - in the mean-time (for 9.1.9.0) I've put in a intermediate patch so that there's less of them.

Member

kares commented Mar 18, 2017

sounds good - in the mean-time (for 9.1.9.0) I've put in a intermediate patch so that there's less of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment