New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPYING is missing Java libraries #4587

Closed
madrob opened this Issue May 3, 2017 · 8 comments

Comments

Projects
None yet
2 participants
@madrob
Contributor

madrob commented May 3, 2017

jruby-complete bundles jline (3 clause bsd) but does not include the license text in its COPYING file.

We had it before, but then lost it in 2da0320

cc: @headius

@headius headius added this to the JRuby 9.1.9.0 milestone May 6, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius May 6, 2017

Member

Yup, we should fix that.

Member

headius commented May 6, 2017

Yup, we should fix that.

@madrob

This comment has been minimized.

Show comment
Hide comment
@madrob

madrob May 8, 2017

Contributor

Cracking open jruby-complete-9.1.8.0.jar I see the following jars:

jar license link
jline/jline/2.11/jline-2.11.jar BSD-3 https://github.com/jline/jline2
jopenssl.jar EPL/GPL/LGPL https://github.com/jruby/jruby-openssl
json/ext/generator.jar Ruby https://github.com/flori/json
json/ext/parser.jar Ruby https://github.com/flori/json
org/bouncycastle/bcpkix-jdk15on/1.56/bcpkix-jdk15on-1.56.jar MIT https://www.bouncycastle.org/java.html
org/bouncycastle/bcprov-jdk15on/1.56/bcprov-jdk15on-1.56.jar MIT https://www.bouncycastle.org/java.html
org/yaml/snakeyaml/1.18/snakeyaml-1.18.jar ASLv2 https://github.com/asomov/snakeyaml
psych.jar EPL/GPL/LGPL https://github.com/ruby/psych
racc/cparse-jruby.jar LGPL https://github.com/tenderlove/racc
readline.jar EPL/GPL/LGPL https://github.com/jruby/jruby-readline

Also, looking at the .class files present, I can account for most of the current ASLv2 list in the current COPYING. I think we'll need to add all these:

folder license link
me/qmx/jitescript ASLv2 https://github.com/qmx/jitescript
jnr/posix EPL/GPL/LGPL https://github.com/jnr/jnr-posix
jnr/x86asm MIT https://github.com/jnr/jnr-x86asm
com/headius/options ASLv2 https://github.com/headius/options
com/headius/invokebinder ASLv2 https://github.com/headius/invokebinder
com/headius/unsafe/fences ASLv2 https://github.com/headius/unsafe-fences
com/jcraft/jzlib BSD-3 http://www.jcraft.com/jzlib/LICENSE.txt

I'm also a little confused about how we bundle with maven. I think I saw it included inside of readline, but that seemed strange enough that I'd rather ask for help than try to research it on my own.

If this list looks complete, then it should just be a matter of collecting the appropriate pieces and updating our COPYING file.

Contributor

madrob commented May 8, 2017

Cracking open jruby-complete-9.1.8.0.jar I see the following jars:

jar license link
jline/jline/2.11/jline-2.11.jar BSD-3 https://github.com/jline/jline2
jopenssl.jar EPL/GPL/LGPL https://github.com/jruby/jruby-openssl
json/ext/generator.jar Ruby https://github.com/flori/json
json/ext/parser.jar Ruby https://github.com/flori/json
org/bouncycastle/bcpkix-jdk15on/1.56/bcpkix-jdk15on-1.56.jar MIT https://www.bouncycastle.org/java.html
org/bouncycastle/bcprov-jdk15on/1.56/bcprov-jdk15on-1.56.jar MIT https://www.bouncycastle.org/java.html
org/yaml/snakeyaml/1.18/snakeyaml-1.18.jar ASLv2 https://github.com/asomov/snakeyaml
psych.jar EPL/GPL/LGPL https://github.com/ruby/psych
racc/cparse-jruby.jar LGPL https://github.com/tenderlove/racc
readline.jar EPL/GPL/LGPL https://github.com/jruby/jruby-readline

Also, looking at the .class files present, I can account for most of the current ASLv2 list in the current COPYING. I think we'll need to add all these:

folder license link
me/qmx/jitescript ASLv2 https://github.com/qmx/jitescript
jnr/posix EPL/GPL/LGPL https://github.com/jnr/jnr-posix
jnr/x86asm MIT https://github.com/jnr/jnr-x86asm
com/headius/options ASLv2 https://github.com/headius/options
com/headius/invokebinder ASLv2 https://github.com/headius/invokebinder
com/headius/unsafe/fences ASLv2 https://github.com/headius/unsafe-fences
com/jcraft/jzlib BSD-3 http://www.jcraft.com/jzlib/LICENSE.txt

I'm also a little confused about how we bundle with maven. I think I saw it included inside of readline, but that seemed strange enough that I'd rather ask for help than try to research it on my own.

If this list looks complete, then it should just be a matter of collecting the appropriate pieces and updating our COPYING file.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius May 8, 2017

Member

I filled in the rest of your chart above (racc and bouncycastle). This looks like a good list and I agree we should note each library in COPYING.

Member

headius commented May 8, 2017

I filled in the rest of your chart above (racc and bouncycastle). This looks like a good list and I agree we should note each library in COPYING.

@madrob

This comment has been minimized.

Show comment
Hide comment
@madrob

madrob May 8, 2017

Contributor

racc is LGPL not GPL according to the link you gave, updated the chart

Contributor

madrob commented May 8, 2017

racc is LGPL not GPL according to the link you gave, updated the chart

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius May 8, 2017

Member

Oops, thanks.

Member

headius commented May 8, 2017

Oops, thanks.

madrob added a commit to madrob/jruby that referenced this issue May 10, 2017

enebo added a commit that referenced this issue May 10, 2017

Merge pull request #4597 from madrob/master
Update COPYING for bundled java licenses #4587
@madrob

This comment has been minimized.

Show comment
Hide comment
@madrob

madrob May 10, 2017

Contributor

PR was merged, thanks!

Contributor

madrob commented May 10, 2017

PR was merged, thanks!

@madrob madrob closed this May 10, 2017

@madrob

This comment has been minimized.

Show comment
Hide comment
@madrob

madrob May 10, 2017

Contributor

Just realized I forgot to include the json libs.

Contributor

madrob commented May 10, 2017

Just realized I forgot to include the json libs.

@madrob madrob reopened this May 10, 2017

madrob added a commit to madrob/jruby that referenced this issue May 10, 2017

headius added a commit that referenced this issue May 10, 2017

Merge pull request #4604 from madrob/master
Include Ruby Licensed json libs in COPYING #4587
@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius May 10, 2017

Member

Ok, all set then!

Member

headius commented May 10, 2017

Ok, all set then!

@headius headius closed this May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment