Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
activation of jar-dependencies in bundler clashes with shipped gem #4740
source "https://rubygems.org" gem "jar-dependencies"
This may be related to mkristian/jar-dependencies#52, but I can't reproduce the issue on jruby 1.7.x, leading me to think it is a 9k problem.
@headius so the problem is that bundler requires 'readline' inside its vendor thor, in the end it is never ever used but readline needs jar-dependencies to load its jars.
I would go for the second option as it is in our domain and its gives IMO improvement onjline issue we saw in the past.
it also relates to #3681 where we also had two solutions:
if am already repacking/shading things then I will also address #3821 in the same PR
my proposed actions would be:
@mkristian Ok so my main concern here is that Ruby 2.5 is gemifying basically everything, which means we're going to need to essentially follow that pattern. We'll want to figure out which gems we can just use, which need some JRuby patches, and which we'll have to replace altogether (probably still needing to push to those names). Moving readline back into core now means we'll just be moving it back out again.
I do agree we should probably start shading everything we ship and do not intend to export.
@headius OK then it is better we leave the readline gem as gem and just shade/repackage the jline and require it without the jar-dependencies. in general it is nice to share even the jars via jar-dependencies but jline was problematic in the past as well, and with this bundler issue, we just repackage it.