Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_inputstream method #4749

Closed
ahmgeek opened this issue Aug 24, 2017 · 2 comments
Closed

to_inputstream method #4749

ahmgeek opened this issue Aug 24, 2017 · 2 comments
Milestone

Comments

@ahmgeek
Copy link

@ahmgeek ahmgeek commented Aug 24, 2017

this is not an actual issue it's just a question regards the method to_inputstream:

  io = java_input_stream.to_io # works for InputStreams, OutputStreams, and NIO Channels
  stream = io.to_inputstream # also to_outputstream and to_channel

Why it's not to_input_stream like to_java_bytes why the naming is not like ruby snake_case convention ?

update:
also to_outputstream shouldn't it be to_output_stream

@ahmgeek ahmgeek changed the title to_inputstreammethod to_inputstream method Aug 24, 2017
@kares
Copy link
Member

@kares kares commented Aug 27, 2017

its simply soft-ware evolution (done by different folks) ... but you're right naming should be consistent 👍

@kares kares added this to the JRuby 9.2.0.0 milestone Aug 27, 2017
@ahmgeek
Copy link
Author

@ahmgeek ahmgeek commented Aug 27, 2017

thanks, while we here I edited the issue to include to_outputstream so it could be to_output_stream 🤗

@kares kares closed this in c22987a Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.