New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_dns_server_list #4755

Closed
ahorek opened this Issue Aug 27, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@ahorek
Contributor

ahorek commented Aug 27, 2017

Environment

jruby 9.2.0.0-SNAPSHOT (2.4.1) 2017-08-20 c22987a Java HotSpot(TM) 64-Bit Server VM 25.131-b11 on 1.8.0_131-b11 +jit [mswin32-x86_64]

#4687

Expected Behavior

get_dns_server_list is not implemented on jruby

nameserver = get_dns_server_list

Actual Behavior

https://github.com/ruby/ruby/blob/202bbda2bf5f25343e286099140fb9282880ecba/ext/win32/resolv/resolv.c

`

jgem install benchmark-ips
ERROR: While executing gem ... (NameError)
undefined local variable or method get_dns_server_list' for Win32::Resolv:Module

@headius

This comment has been minimized.

Member

headius commented Aug 28, 2017

Indeed it is not! Perhaps you can help?

@ahorek

This comment has been minimized.

Contributor

ahorek commented May 5, 2018

#5158 it's a workaround and it doesn't fix the original issue https://bugs.ruby-lang.org/issues/12604
I wasn't able to find simmilar API in Java. Can I use the C extension from iphlpapi.h in JRuby using FFI / JNI?

@headius

This comment has been minimized.

Member

headius commented May 14, 2018

@ahorek If it's possible to do it through Ruby FFI that would probably be the quickest option. Go for it, and feel free to ping gitter or IRC with questions!

@headius headius added this to the JRuby 9.2.0.0 milestone May 14, 2018

@headius

This comment has been minimized.

Member

headius commented May 14, 2018

Marking for 9.2 since we at least seem to have a workaround.

@ahorek

This comment has been minimized.

Contributor

ahorek commented May 14, 2018

thanks, I'll look into it!

@ahorek ahorek closed this May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment