Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Class#subclasses from jruby/core_ext.rb #4760

Closed
kares opened this issue Aug 28, 2017 · 1 comment
Closed

deprecate Class#subclasses from jruby/core_ext.rb #4760

kares opened this issue Aug 28, 2017 · 1 comment
Assignees
Milestone

Comments

@kares
Copy link
Member

@kares kares commented Aug 28, 2017

as an outcome to eventually remove the core_ext/class.rb extension
(which colides with ActiveSupport's own subclasses whenever jruby/core_ext is loaded)

JRuby should deprecate the method and maybe provide an alternative JRuby.subclasses_for(klass)

... so that we can eventually remove it completely at some point later

@kares kares added this to the JRuby 9.2.0.0 milestone Aug 28, 2017
@kares kares changed the title deprecate Class#subclasses jruby/core_ext.rb deprecate Class#subclasses from jruby/core_ext.rb Aug 28, 2017
@headius
Copy link
Member

@headius headius commented Sep 5, 2017

I always wished subclasses would get added as a standard Class method rather than everyone relying on Rails's patch.

@kares kares self-assigned this May 21, 2018
kares added a commit that referenced this issue May 21, 2018
... this essentially clashes with Rails's core_ext

resolves #4760 (follow-up on 9a3fe9c)
@kares kares closed this in 003b9ee May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.