New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Class#subclasses from jruby/core_ext.rb #4760

Closed
kares opened this Issue Aug 28, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@kares
Member

kares commented Aug 28, 2017

as an outcome to eventually remove the core_ext/class.rb extension
(which colides with ActiveSupport's own subclasses whenever jruby/core_ext is loaded)

JRuby should deprecate the method and maybe provide an alternative JRuby.subclasses_for(klass)

... so that we can eventually remove it completely at some point later

@kares kares added this to the JRuby 9.2.0.0 milestone Aug 28, 2017

@kares kares changed the title from deprecate Class#subclasses jruby/core_ext.rb to deprecate Class#subclasses from jruby/core_ext.rb Aug 28, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Sep 5, 2017

Member

I always wished subclasses would get added as a standard Class method rather than everyone relying on Rails's patch.

Member

headius commented Sep 5, 2017

I always wished subclasses would get added as a standard Class method rather than everyone relying on Rails's patch.

@kares kares self-assigned this May 21, 2018

kares added a commit that referenced this issue May 21, 2018

deprecate Class#subclasses from jruby/core_ext ... move it to JRuby
... this essentially clashes with Rails's core_ext

resolves #4760 (follow-up on 9a3fe9c)

@kares kares closed this in 003b9ee May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment