New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml/store has a hack until we get an updated psych. #4779

Closed
enebo opened this Issue Sep 5, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@enebo
Member

enebo commented Sep 5, 2017

Offshoot of #4770. I patched around the problem of pstore using ASCII-8BIT as an encoding by adding the same method to yaml/store which picks UTF-8 as the encoding.

@enebo enebo added this to the JRuby 9.2.0.0 milestone Sep 5, 2017

enebo added a commit that referenced this issue Sep 5, 2017

Fixes #4770. YAML::Store does not retrieve UTF8 values correctly in r…
…ead-only mode.

This is just a work around until Psych is updated with a proper fix.  I opened
#4779 to make sure I delete this fix later.

enebo added a commit that referenced this issue Sep 5, 2017

Fixes #4770. YAML::Store does not retrieve UTF8 values correctly in r…
…ead-only mode.

This is just a work around until Psych is updated with a proper fix.  I opened
#4779 to make sure I delete this fix later.
@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Sep 7, 2017

Member

Link to #4784.

Member

headius commented Sep 7, 2017

Link to #4784.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Sep 7, 2017

Member

This will fix itself when we update to Psych 3.0.0.

Member

headius commented Sep 7, 2017

This will fix itself when we update to Psych 3.0.0.

headius added a commit to jruby/ruby that referenced this issue Oct 12, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius May 16, 2018

Member

Psych 3.0.2 will ship with 9.2.

Member

headius commented May 16, 2018

Psych 3.0.2 will ship with 9.2.

@headius headius closed this May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment