New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psych needs update once 3.0.0 is released #4784

Closed
headius opened this Issue Sep 7, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@headius
Member

headius commented Sep 7, 2017

I am excluding some Psych tests from 2.2.4 that have not been updated for Ruby 2.4 changes to DateTime#to_time. These tests are fixed on Psych master but we can't update them until there's a non-beta Psych release.

  1) Failure:
Psych::JSON::TestStream#test_datetime [/home/travis/build/jruby/jruby/test/mri/psych/json/test_stream.rb:106]:
Expected /\{"a":\ "2010\-10\-10\ 00:00:00\.000000000\ \+00:00"\}\n/ to match "--- {\"a\": \"2010-10-10 00:00:00.000000000 Z\"}\n...\n".

  2) Failure:
Psych::TestJSONTree#test_datetime [/home/travis/build/jruby/jruby/test/mri/psych/test_json_tree.rb:63]:
--- expected
+++ actual
@@ -1,2 +1,2 @@
-"{\"a\": \"2010-10-10 00:00:00.000000000 +00:00\"}
+"{\"a\": \"2010-10-10 00:00:00.000000000 Z\"}
 "
@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius May 16, 2018

Member

Psych 3.0.2 will ship with JRuby 9.2.

Member

headius commented May 16, 2018

Psych 3.0.2 will ship with JRuby 9.2.

@headius headius closed this May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment