New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby 9.2.0.0-SNAPSHOT does not return result of `rake` via `system` #4809

Closed
koic opened this Issue Oct 10, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@koic

koic commented Oct 10, 2017

Environment

  • jruby 9.2.0.0-SNAPSHOT (2.4.1) 2017-09-07 b6a4df9 OpenJDK 64-Bit Server VM 24.121-b00 on 1.7.0_121-b00 +jit [linux-x86_64]
  • Linux rails-dev-box 3.2.0-23-generic #36-Ubuntu SMP Tue Apr 10 20:39:51 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux

Expected Behavior

This is behavior of JRuby 9.1.13.0 and MRI 2.4.2.

% rvm use jruby-9.1.13.0
Using /home/vagrant/.rvm/gems/jruby-9.1.13.0
% rake --version
rake, version 12.1.0
% ruby -e 'system("rake --version")'
rake, version 12.1.0

Actual Behavior

This is behavior of JRuby 9.2.0.0-SNAPSHOT.

% rvm use jruby-head
Using /home/vagrant/.rvm/gems/jruby-head
% rake --version
rake, version 12.1.0
% ruby -e 'system("rake --version")' # Do not return `rake` version

JRuby 9.2.0.0-SNAPSHOT does not return result of rake --version via system method. The same phenomenon will occur even if rake --version is replaced with bundle --version.

I noticed this issue is occurring in Travis CI of bbatsov/rubocop repository.
https://travis-ci.org/bbatsov/rubocop/jobs/285144081#L712-L714

@headius headius added this to the JRuby 9.2.0.0 milestone Oct 30, 2017

koic added a commit to koic/rubocop that referenced this issue Nov 13, 2017

Drop rbx-3 from travis.yml
## Summary

rbx-3 has been failed in Travis CI for a long while.
It seems that it already failed when upgrading from rbx-2 to rbx-3.
rubocop-hq#2706

It seems that there is no activity while failing with `allow_failures`.
So I think that it is not necessary to use CI resources at present.
When passing the test with rbx-3, I think that it is better to add it
again to travis.yml.

## Other Information

jruby-head (jruby 9.2.0.0-SNAPSHOT) will progress as soon as the
following Issue is resolved.
jruby/jruby#4809

@koic koic referenced this issue Nov 13, 2017

Merged

Drop rbx-3 from travis.yml #5048

7 of 11 tasks complete

bbatsov added a commit to rubocop-hq/rubocop that referenced this issue Nov 13, 2017

Drop rbx-3 from travis.yml
## Summary

rbx-3 has been failed in Travis CI for a long while.
It seems that it already failed when upgrading from rbx-2 to rbx-3.
#2706

It seems that there is no activity while failing with `allow_failures`.
So I think that it is not necessary to use CI resources at present.
When passing the test with rbx-3, I think that it is better to add it
again to travis.yml.

## Other Information

jruby-head (jruby 9.2.0.0-SNAPSHOT) will progress as soon as the
following Issue is resolved.
jruby/jruby#4809

koic added a commit to koic/rubocop that referenced this issue Mar 22, 2018

Drop jruby-head (jruby 9.2.0.0-SNAPSHOT) from .travis.yml
jruby-head has been failed in Travis CI for a long while.
https://travis-ci.org/bbatsov/rubocop/builds/356172495

When I opened PR #5048 it already failed.

I've been opened an issue to jruby/jruby as to why CI fails.
jruby/jruby#4809

I'd like to add it again to .travis.yml when the above JRuby
issue is solved.
@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Mar 22, 2018

Member

Thanks for the report! This is surprising, but I believe I saw another bug with the same problem.

I am unable to reproduce so far on this macOS system:

$ ruby -v -e 'system("rake --version")'
jruby 9.2.0.0-SNAPSHOT (2.4.1) 2018-03-22 b4b496a Java HotSpot(TM) 64-Bit Server VM 25.161-b12 on 1.8.0_161-b12 +jit [darwin-x86_64]
rake, version 10.4.2

Will investigate on other platforms.

Member

headius commented Mar 22, 2018

Thanks for the report! This is surprising, but I believe I saw another bug with the same problem.

I am unable to reproduce so far on this macOS system:

$ ruby -v -e 'system("rake --version")'
jruby 9.2.0.0-SNAPSHOT (2.4.1) 2018-03-22 b4b496a Java HotSpot(TM) 64-Bit Server VM 25.161-b12 on 1.8.0_161-b12 +jit [darwin-x86_64]
rake, version 10.4.2

Will investigate on other platforms.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Mar 22, 2018

Member

Sorry we didn't get to this until now...I had not even seen it yet!

Member

headius commented Mar 22, 2018

Sorry we didn't get to this until now...I had not even seen it yet!

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Mar 22, 2018

Member

I have reproduced it on Ubuntu. Investigating!

Member

headius commented Mar 22, 2018

I have reproduced it on Ubuntu. Investigating!

@headius headius closed this in b0f7aaf Mar 22, 2018

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Mar 22, 2018

Member

Fixed! A refactoring done in August accidentally removed a PATH lookup step in process launching.

I am very surprised this did not trigger any other failures in our CI. Perhaps you can make a spec for https://github.com/ruby/spec so we never regress again?

Member

headius commented Mar 22, 2018

Fixed! A refactoring done in August accidentally removed a PATH lookup step in process launching.

I am very surprised this did not trigger any other failures in our CI. Perhaps you can make a spec for https://github.com/ruby/spec so we never regress again?

@koic

This comment has been minimized.

Show comment
Hide comment
@koic

koic Mar 23, 2018

Thanks for the fixes and advice! I'm interested in https://github.com/ruby/spec and I'd like to try it later.

koic commented Mar 23, 2018

Thanks for the fixes and advice! I'm interested in https://github.com/ruby/spec and I'd like to try it later.

headius added a commit that referenced this issue Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment