New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jitescript jar clashes with bundled jitescript classes in jruby-complete jar #4831

Closed
mpe85 opened this Issue Oct 27, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@mpe85

mpe85 commented Oct 27, 2017

In our project we have jitescript-0.4.1.jar on the classpath because another 3rd party library has a dependency to it.
But this clashes with jitescript bundled with the jruby-complete.jar.
I'm new to jruby, so I don't know if this can be changed easily.
The main problem is that the bundled jitescript classes are not the original ones, because they include ASM artifacts which is bundled in the jruby jar (org.jruby.org.objectweb.asm) instead of the original ASM artifacts (org.objectweb.asm).
Maybe the bundled jitescript classes can also be moved to the package org.jruby, this would avoid the clash.
This issue should apply to all 9.x versions of jruby.

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Oct 27, 2017

Member

right I see the problem: we repackaged the org.objectweb.asm.* but now it clashed with me.qmx.jitescript.* being on the classpath twice.

to repackage all the 3rd party jars would be the right thing as it easily can conflict in a similar manner with gems and their bundled jars. and for the OSGi it is also better to avoid non org.jruby classes altogether (#3821)

Member

mkristian commented Oct 27, 2017

right I see the problem: we repackaged the org.objectweb.asm.* but now it clashed with me.qmx.jitescript.* being on the classpath twice.

to repackage all the 3rd party jars would be the right thing as it easily can conflict in a similar manner with gems and their bundled jars. and for the OSGi it is also better to avoid non org.jruby classes altogether (#3821)

@headius headius added this to the JRuby 9.1.14.0 milestone Oct 27, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Oct 27, 2017

Member

I'll add jitescript to shade.

Member

headius commented Oct 27, 2017

I'll add jitescript to shade.

@headius headius closed this in d44209e Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment