Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
popen doesn't work on Windows #4843
Provide at least:
In jruby 9.1.13, this command outputs "a"
In jruby 9.1.14, no return
On Linux, it returns "a"
Ok, well my first suspect turned out to be right: I can see the data is buffered in the JDK-provided streams. This means one of two things: we were not able to unwrap the buffering, or chose not to for various reasons.
Some versions of JDK (I think 7+, unfortunately) now drive the subprocess streams by themselves, constantly draining them. This makes true interactive subprocesses impossible, and along with them many uses of Ruby. On UNIX platforms we have worked around this by implementing our own process logic that uses posix_spawn and achieves good compatibility. However, on Windows, process management is more complicated, and we have not yet had the resources to mimic the logic in MRI.
I do not know why this would have changed from 9.1.13 to 9.1.14, however. I'll review logs for changes to process and IO logic and see if something jumps out.
This is fixed. It appears to have been a copy/paste bug, using the wrong type of stream for reflection during stream unwrapping.
My best recommendation for the moment would be to stick to 9.1.13 until we can spin a 9.1.15 release. That will likely happen in a couple weeks, after RubyConf.