New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead Exception in RealClassGenerator #4880

Closed
nglorioso opened this Issue Dec 1, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@nglorioso
Contributor

nglorioso commented Dec 1, 2017

new RuntimeException(newClass.getInterfaces()[0].getClassLoader() + " " + interfaces[0].getClassLoader());

This line creates an exception, but doesn't throw it. If thrown, a number of CI tests fail: https://travis-ci.org/jruby/jruby/builds/305072247

This condition/exception should be removed if it's not needed, or the exception should be thrown and the relevant tests fixed.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Dec 5, 2017

Member

The fact that so many tests fail tells me this condition is no longer valid, but I'll take a deeper look.

Member

headius commented Dec 5, 2017

The fact that so many tests fail tells me this condition is no longer valid, but I'll take a deeper look.

@headius headius added this to the JRuby 9.1.15.0 milestone Dec 5, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Dec 5, 2017

Member

The condition is backwards. I'll fix in a moment.

Member

headius commented Dec 5, 2017

The condition is backwards. I'll fix in a moment.

headius added a commit that referenced this issue Dec 5, 2017

@headius headius closed this Dec 5, 2017

headius added a commit that referenced this issue Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment