New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly represent all encodings in methods/constants/variables/symbols #4965

Closed
enebo opened this Issue Jan 11, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@enebo
Member

enebo commented Jan 11, 2018

JRuby has had a limitation up through JRuby 9.1.x where some indentifiers which do not properly map to a Java charset are not possible beacuse internally we store all identifiers as Java Strings.

The solution to this is partially to move as much internally to using ByteList as we can. For things where this would not work out well we will still use java.lang.String but we will store those strings as an iso_8859_1 raw piece of data. Anything which accesses those String will need also to have their encoding and if they don't we will assume they are utf-8 data. This largely will allow things we could not do in the past to start working but things from the past which did work will still work since pretty much everything is utf-8.

  • [#4828 ]
  • [ RuntimeError with compiled multi-byte variable #4660 ]
  • [ define_method using symbols string syntax works incorrectly #3880 ]
  • [ encoding of utf8 symbols (eg. :λ) #3719 ]
  • [ Identifier-keyed tables must always use raw or always use encoded identifiers #3697 ]
  • [ Multibyte identifiers not marshaled correctly #3688 ]
  • [ method does not return valid symbol when Non-ASCII method #914 ]
  • [The & operator doesn't work with quoted symbols #5066]

@enebo enebo added the feature label Jan 11, 2018

@enebo enebo added this to the JRuby 9.2.0.0 milestone Jan 11, 2018

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Jan 11, 2018

Member

Current work in progress for this feature is happening on bytelist_love. This feature should still figure out all issues reported against encoding issues and attach them to this issue.

Member

enebo commented Jan 11, 2018

Current work in progress for this feature is happening on bytelist_love. This feature should still figure out all issues reported against encoding issues and attach them to this issue.

@headius headius referenced this issue Mar 27, 2018

Open

JRuby 9.2 Projects #5119

6 of 15 tasks complete

@enebo enebo modified the milestones: JRuby 9.2.0.0, JRuby 9.2.1.0 May 24, 2018

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Jun 12, 2018

Member

Closing this feature (should have for 9.2.0.0). Only #3688 is not fixed and it is targetted for 9.2.1.0. I will look into it (it might not even technically be part of this...unsure).

Member

enebo commented Jun 12, 2018

Closing this feature (should have for 9.2.0.0). Only #3688 is not fixed and it is targetted for 9.2.1.0. I will look into it (it might not even technically be part of this...unsure).

@enebo enebo closed this Jun 12, 2018

@enebo enebo modified the milestones: JRuby 9.2.1.0, JRuby 9.2.0.0 Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment