PTY.open unusable because of fcntl error #5004
Closed
Milestone
Comments
Fallout from adding CLOEXEC support; now it is defined so code runs that didn't before, but not all paths have been fixed to support it. |
headius
added a commit
that referenced
this issue
Jan 24, 2018
Note that this logic is still wrong when attempting to clear flags since it only looks for them to be set. We should mimic CRuby's fcntl logic when we have access to a real file descriptor, and use the current logic (with fixes for clearing flags) as a fallback only.
Fixed for 9.1.16 by softening the restrictions on fcntl flags. The logic in there is not correct yet, since it doesn't clear flags and only sets specific ones (NONBLOCK and CLOEXEC) but it works properly again (and is no worse than before). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
MRI
Actual Behavior
The text was updated successfully, but these errors were encountered: