Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression or bad merge in string interpolation #5062

Closed
headius opened this Issue Feb 24, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@headius
Copy link
Member

commented Feb 24, 2018

I believe this failure (on ruby-2.5 branch) is a result of merging the fix for #5052:

     [exec]   test_parse_invalid_gvar:				F
     [exec] ===============================================================================
     [exec] Failure: test_parse_invalid_gvar(TestParsing)
     [exec] /home/travis/build/jruby/jruby/test/jruby/test_parsing.rb:46:in `test_parse_invalid_gvar'
     [exec]      43:     assert_equal '#${', eval('"#${"')
     [exec]      44:     assert_equal ' #${', eval('" #${"')
     [exec]      45:     assert_equal ' # ##${', eval('" # ##${"')
     [exec]   => 46:     assert_equal " \#${\n", eval("<<E\n \#$\{\nE\n")
     [exec]      47:     assert_equal " # #\#${\n", eval("<<E\n \# \#\#$\{\nE\n")
     [exec]      48:   end
     [exec]      49: end
     [exec] <" \#${\n"> expected but was
     [exec] <" \#{\n">
     [exec] 
     [exec] diff:
     [exec] ?  #${
     [exec] ===============================================================================
     [exec] : (0.037889)

This does still pass with CRuby 2.5.0. Perhaps something merged badly?

@headius headius added this to the JRuby 9.2.0.0 milestone Feb 24, 2018

@headius

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2018

This is failing in the JRuby suite. I have not audited the other suites for any similar failures.

@enebo

This comment has been minimized.

Copy link
Member

commented Feb 24, 2018

Crazy sauce. Someone fixed similar expansions on master for heredocs and then also added these tests. These tests are not on 9.1 but are broken on 9.1 (always have been too). So my fix fixed this in StringTerm but regressed a fix only on master for heredocs after the merge.

@enebo enebo closed this in d532366 Feb 24, 2018

enebo added a commit that referenced this issue Feb 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.