Numeric#step yields Floats instead of Integers #5078
Closed
Milestone
Comments
@kares can I take this one? |
Sure Raphael, go for it ... |
Ugh. How is this not failing specs or tests? |
Confirmed still broken in 9.1 HEAD. |
Confirmed still broken on master and jruby-9.1 HEAD. |
@kares Ok, thanks |
@raphaeltelatim I'm going to tackle this one since we're getting close to 9.1.17 release time. If you started on it, let me know. |
headius
added a commit
that referenced
this issue
Apr 12, 2018
This includes the following changes: * Re-port Numeric#step logic and related functions. * Re-port Numeric#step enumerator size logic. * Modify ArgsUtil.extractKeywordArgs to use UNDEF instead of nil. * Update tags for Numeric, Fixnum, Bignum, Integer, Float (no changes for last two).
I have fully updated the Numeric#step and Numeric#step enumerator size logic from MRI 2.3 (for 9.1) and MRI 2.5 (for 9.2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Expected Behavior
When I call
Numeric#step
on an Integer with an Integer step, MRI yields Integers:On the other hand, when either the receiver or the step is a Float, MRI yields Floats:
Actual Behavior
On JRuby
Numeric#step
yields Floats regardless of whether the receiver and step are Integers or Floats:The text was updated successfully, but these errors were encountered: