Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krypt is not 1.8-compatible #516

Closed
BanzaiMan opened this Issue Jan 29, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@BanzaiMan
Copy link
Member

BanzaiMan commented Jan 29, 2013

https://github.com/jruby/jruby/blob/master/lib/ruby/shared/krypt.rb contains require_relative, so it is not 1.8-compatible. I haven't looked at the code in detail, so I am not sure how reliant krypt is on 1.9 features.

If we can't bend it to fit, we should postpone incorporating it until we drop the 1.8 support, or devise a means to disable krypt in the 1.8 mode.

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Jan 29, 2013

It seems it would be trivial to have it raise if we are in 1.8 mode. Since krypt is required for us to run rails 4, I don't think we should pull this out even if we can never make it run in 1.8 mode?

With that said I have not looked at what 1.9 bits are in this and how easy it would be to make it work in 1.8 :)

enebo added a commit that referenced this issue Jan 29, 2013

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Jan 29, 2013

I added the bits to make krypt not load if not 1.9. I ran some 1.8/openssl tests and things still seem to work so kyrpt appears to be supplementary. Since the main reason for krypt seems to Rails 4 which only runs on 1.9+, I am inclined to think this is enough work and we can close this. If someone does want this behavior for 1.8 then they can do the extra work with relative_require and any other 1.9isms and make it work.

@enebo enebo closed this Jan 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.