Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRUBY 9.2.0.0: Assertion Failure when Reporting RSpec Failure #5193

Closed
original-brownbear opened this Issue May 25, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@original-brownbear
Copy link
Contributor

original-brownbear commented May 25, 2018

I tried upgrading Logstash to 9.2.0.0, unfortunately the RSpec doesn't seem to behave correctly there.
When trying to report a test failure and having Java's -ea set, I run into below exception.
Unfortunately this doesn't reproduce on every test failure. The failure is also reported correctly when Java assertions aren't enabled.

Unfortunately the best reproducer I can offer so far is to:

  1. Clone this branch of LS https://github.com/original-brownbear/logstash/tree/jruby-9.2-reproducer
  2. Run ./gradlew rubyTests
  3. Wait ~10 min
  4. See below error
Unhandled Java exception: java.lang.AssertionError: valueNode is not null
java.lang.AssertionError: valueNode is not null
                                                                <init> at org/jruby/ast/AssignableNode.java:49
                                                                <init> at org/jruby/ast/LocalAsgnNode.java:55
                                                                assign at org/jruby/parser/StaticScope.java:482
                                                                assign at org/jruby/parser/StaticScope.java:403
                                                  assignableIdentifier at org/jruby/ext/ripper/RipperParserBase.java:122
                                                               execute at org/jruby/ext/ripper/RipperParser.java:2271
                                                               yyparse at org/jruby/ext/ripper/RipperParser.java:1594
                                                               yyparse at org/jruby/ext/ripper/RipperParser.java:1485
                                                                 parse at org/jruby/ext/ripper/RipperParserBase.java:80
                                                                 parse at org/jruby/ext/ripper/RubyRipper.java:343
                                                                  call at org/jruby/ext/ripper/RubyRipper$INVOKER$i$0$0$parse.gen:-1
                                                                  call at org/jruby/internal/runtime/methods/JavaMethod.java:813
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                                  sexp at /Users/brownbear/src/logstash/vendor/jruby/lib/ruby/stdlib/ripper/sexp.rb:33
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                                   ast at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-support-3.7.1/lib/rspec/support/source.rb:45
                                         RUBY$method$ast$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_support_minus_3_dot_7_dot_1/lib/rspec/support//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-support-3.7.1/lib/rspec/support/source.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                  nodes_by_line_number at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-support-3.7.1/lib/rspec/support/source.rb:61
                        RUBY$method$nodes_by_line_number$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_support_minus_3_dot_7_dot_1/lib/rspec/support//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-support-3.7.1/lib/rspec/support/source.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                      location_nodes_at_beginning_line at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:118
            RUBY$method$location_nodes_at_beginning_line$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                       expression_node at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:96
                             RUBY$method$expression_node$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                            line_range_of_location_nodes_in_expression at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:88
  RUBY$method$line_range_of_location_nodes_in_expression$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                              line_range_of_expression at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:57
                    RUBY$method$line_range_of_expression$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                      expression_lines at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:42
                            RUBY$method$expression_lines$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                           extract_expression_lines_at at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/snippet_extractor.rb:31
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                     read_failed_lines at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:218
                           RUBY$method$read_failed_lines$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                             failure_slash_error_lines at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:163
                   RUBY$method$failure_slash_error_lines$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                block in failure_lines at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:150
                                                           yieldDirect at org/jruby/runtime/CompiledIRBlockBody.java:162
                                                                 yield at org/jruby/runtime/BlockBody.java:114
                                                                 yield at org/jruby/runtime/Block.java:165
                                                                   tap at org/jruby/RubyKernel.java:1876
                                                                  call at org/jruby/RubyKernel$INVOKER$s$0$0$tap.gen:-1
                                                                  call at org/jruby/internal/runtime/methods/JavaMethod.java:537
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:168
                                                         failure_lines at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:149
                               RUBY$method$failure_lines$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                               colorized_message_lines at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:34
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                       formatted_message_and_backtrace at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:240
             RUBY$method$formatted_message_and_backtrace$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                 fully_formatted_lines at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:86
                       RUBY$method$fully_formatted_lines$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                       fully_formatted at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/exception_presenter.rb:78
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                       fully_formatted at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/notifications.rb:200
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                              block in fully_formatted_failed_examples at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/notifications.rb:114
                                                            callDirect at org/jruby/runtime/CompiledIRBlockBody.java:151
                                                                  call at org/jruby/runtime/IRBlockBody.java:77
                                                                  call at org/jruby/runtime/IRBlockBody.java:61
                                                                  call at org/jruby/runtime/Block.java:146
                                                                  call at org/jruby/RubyEnumerable.java:1116
                                                               doYield at org/jruby/runtime/CallBlock.java:92
                                                                 yield at org/jruby/runtime/BlockBody.java:116
                                                                 yield at org/jruby/runtime/Block.java:165
                                                                  each at org/jruby/RubyArray.java:1801
                                                                  call at org/jruby/RubyArray$INVOKER$i$0$0$each.gen:-1
                                                                  call at org/jruby/internal/runtime/methods/JavaMethod.java:537
                                                               finvoke at org/jruby/RubyClass.java:525
                                                                invoke at org/jruby/runtime/Helpers.java:349
                                                              callEach at org/jruby/RubyEnumerable.java:142
                                                 each_with_indexCommon at org/jruby/RubyEnumerable.java:1150
                                                       each_with_index at org/jruby/RubyEnumerable.java:1180
                                                                  call at org/jruby/RubyEnumerable$INVOKER$s$0$0$each_with_index.gen:-1
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:168
                                       fully_formatted_failed_examples at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/notifications.rb:113
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                         dump_failures at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/base_text_formatter.rb:32
                               RUBY$method$dump_failures$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core/formatters//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/formatters/base_text_formatter.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                               finvoke at org/jruby/RubyClass.java:525
                                                                  send at org/jruby/RubyBasicObject.java:1752
                                                                  call at org/jruby/RubyBasicObject$INVOKER$i$send.gen:-1
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                       block in notify at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/reporter.rb:206
                                                           yieldDirect at org/jruby/runtime/CompiledIRBlockBody.java:162
                                                                 yield at org/jruby/runtime/BlockBody.java:114
                                                                 yield at org/jruby/runtime/Block.java:165
                                                                  each at org/jruby/RubyArray.java:1801
                                                                notify at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/reporter.rb:205
                                      RUBY$method$notify$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/reporter.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                       block in finish at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/reporter.rb:175
                                                           yieldDirect at org/jruby/runtime/CompiledIRBlockBody.java:162
                                                         yieldSpecific at org/jruby/runtime/IRBlockBody.java:85
                                                         yieldSpecific at org/jruby/runtime/Block.java:134
                                                         yieldSpecific at org/jruby/ir/runtime/IRRuntimeHelpers.java:463
                                                         yieldSpecific at org/jruby/ir/targets/YieldSite.java:119
                                                           close_after at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/reporter.rb:191
                                 RUBY$method$close_after$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/reporter.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:168
                                                                finish at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/reporter.rb:171
                                      RUBY$method$finish$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/reporter.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                                report at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/reporter.rb:81
                                      RUBY$method$report$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/reporter.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:168
                                                             run_specs at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:112
                                   RUBY$method$run_specs$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                                   run at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:87
                                         RUBY$method$run$0$__VARARGS__ at Users/brownbear/src/logstash/vendor/bundle/jruby/$2_dot_3_dot_0/gems/rspec_minus_core_minus_3_dot_7_dot_1/lib/rspec/core//Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:-1
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                                   run at /Users/brownbear/src/logstash/vendor/bundle/jruby/2.3.0/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:71
                                                                  call at org/jruby/internal/runtime/methods/CompiledIRMethod.java:75
                                                                  call at org/jruby/internal/runtime/methods/MixedModeIRMethod.java:88
                                                                invoke at org/jruby/ir/targets/InvokeSite.java:174
                                                                <main> at /Users/brownbear/src/logstash/lib/bootstrap/rspec.rb:13
                                                   invokeWithArguments at java/lang/invoke/MethodHandle.java:627
                                                                  load at org/jruby/ir/Compiler.java:94
                                                             runScript at org/jruby/Ruby.java:852
                                                           runNormally at org/jruby/Ruby.java:771
                                                           runNormally at org/jruby/Ruby.java:789
                                                           runFromMain at org/jruby/Ruby.java:601
                                                         doRunFromMain at org/jruby/Main.java:415
                                                           internalRun at org/jruby/Main.java:307
                                                                   run at org/jruby/Main.java:234
                                                                  main at org/jruby/Main.java:206

@original-brownbear original-brownbear referenced this issue May 25, 2018

Closed

Upgrade to JRuby 9.2 (Ruby 2.5) #9660

0 of 1 task complete

@enebo enebo added this to the JRuby 9.2.1.0 milestone May 25, 2018

@enebo

This comment has been minimized.

Copy link
Member

enebo commented May 25, 2018

3c97f06 fixes this by removing the assertion. In parser valueNode can be null for a few cases like (a = ()). Amazed you do not see this on 1.7.x or 9.1.x as well with -ea. In the past I attempted to make all callers pass in implicitnilnode in null cases but it was never really robust.

@enebo enebo closed this May 25, 2018

@original-brownbear

This comment has been minimized.

Copy link
Contributor Author

original-brownbear commented May 25, 2018

@enebo thanks!

@enebo

This comment has been minimized.

Copy link
Member

enebo commented May 25, 2018

@original-brownbear @headius and I will be travelling next week and will be a bit spotty but keep the reports coming. We would love to see logstash be able to migrate much easier than the 9.1.x series was for you (ignore this bad grammar).

@original-brownbear original-brownbear referenced this issue May 29, 2018

Closed

[META] Java 11 Support #9345

1 of 3 tasks complete
@original-brownbear

This comment has been minimized.

Copy link
Contributor Author

original-brownbear commented Jun 11, 2018

@enebo @headius coming back to this:

I tried upgrading to master today and I'm still experiencing a few issues (will open tickets here shortly). Since this is hampering our efforts in getting LS running on Java 10 we were wondering if you were open to making Logstash part of your test suite? (what we're ideally be looking for is a run of all of LS's unit tests to get rid of the current cycle of fixes in one place and regressions elsewhere).

We'd be able/willing to contribute the code and if necessary the infrastructure for running those tests happily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.