Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current head switches on +indy before 1.7update14 #532

Closed
tobsch opened this Issue Feb 12, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@tobsch
Copy link

commented Feb 12, 2013

Hi there,

it seems that the current head will switch on indy by default, even for current & older jvms:

$ ruby -v
jruby 1.7.3.dev (1.9.3p327) 2013-02-10 0a868ab on Java HotSpot(TM) 64-Bit Server VM 1.7.0_13-b20 +indy [darwin-x86_64]

same happens for u9

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Feb 13, 2013

Looks like that's the intended behavior (8e20824#L3R98); if HotSpot build is less than 24 but the Java version is at least 1.7, then invokedynamic is enabled.

Are you seeing some adverse effects due to invokedynamic?

@tobsch

This comment has been minimized.

Copy link
Author

commented Feb 13, 2013

nope, i did not really test so far: charlie told me that the indy fixes come with u14 and asked me to open up an issue.
i could do a test with u13 though...

@tobsch

This comment has been minimized.

Copy link
Author

commented Feb 13, 2013

If i understand the code right, it is meant to switch on indy in 1.7 builds >= b24.
The last else part seems to be the bug as it enables indy on all 1.7 builds?

if (!javaVersion.equals("") && new BigDecimal(javaVersion).compareTo(new BigDecimal("1.7")) >= 0){

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Feb 13, 2013

Yeah, I think you're right. That branch should be testing if we are on HotSpot, but that logic is missing. Fix is forthcoming.

@ghost ghost assigned BanzaiMan Feb 13, 2013

@BanzaiMan BanzaiMan closed this in 3294b22 Feb 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.