Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression from Date.parse optimizations #5396

Closed
enebo opened this Issue Oct 31, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@enebo
Copy link
Member

enebo commented Oct 31, 2018

Apparently AS depends on _parse parts output behaving a particular way that #5255 must have slightly changed:

jruby -r active_support/core_ext/string/conversions -e 'p "10:00".to_time'
NoMethodError: undefined method `+' for nil:NilClass

@enebo enebo added the regression label Oct 31, 2018

@enebo enebo added this to the JRuby 9.2.1.0 milestone Oct 31, 2018

@enebo

This comment has been minimized.

Copy link
Member Author

enebo commented Oct 31, 2018

Minimized:

require 'date'

parts = Date._parse("10:00", false)
p parts.fetch(:sec, 0)

@enebo enebo closed this in b839a05 Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.