Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jruby-dist-9.2.1.0-bin.tar.gz files is missing gem lib/exe folders #5420

Closed
jeremyevans opened this Issue Nov 6, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@jeremyevans
Copy link
Contributor

jeremyevans commented Nov 6, 2018

Environment

jruby 9.2.1.0 (2.5.0) 2018-11-06 7b14404 OpenJDK 64-Bit Server VM 25.172-b11 on 1.8.0_172-b11 +jit [OpenBSD-x86_64]

Expected Behavior

All gem lib/exe directories should be populated. jruby -S rake should work.

Actual Behavior

tar ztf jruby-dist-9.2.1.0-bin.tar.gz | fgrep jruby-9.2.1.0/lib/ruby/gems/shared/gems output:

jruby-9.2.1.0/lib/ruby/gems/shared/gems/net-telnet-0.1.1/LICENSE.txt
jruby-9.2.1.0/lib/ruby/gems/shared/gems/net-telnet-0.1.1/net-telnet.gemspec
jruby-9.2.1.0/lib/ruby/gems/shared/gems/net-telnet-0.1.1/Gemfile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/net-telnet-0.1.1/Rakefile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/net-telnet-0.1.1/README.md
jruby-9.2.1.0/lib/ruby/gems/shared/gems/net-telnet-0.1.1/.travis.yml
jruby-9.2.1.0/lib/ruby/gems/shared/gems/rake-12.3.0/Gemfile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/rake-12.3.0/History.rdoc
jruby-9.2.1.0/lib/ruby/gems/shared/gems/rake-12.3.0/rake.gemspec
jruby-9.2.1.0/lib/ruby/gems/shared/gems/rake-12.3.0/Rakefile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/rake-12.3.0/MIT-LICENSE
jruby-9.2.1.0/lib/ruby/gems/shared/gems/rake-12.3.0/CONTRIBUTING.rdoc
jruby-9.2.1.0/lib/ruby/gems/shared/gems/rake-12.3.0/README.rdoc
jruby-9.2.1.0/lib/ruby/gems/shared/gems/power_assert-1.1.1/BSDL
jruby-9.2.1.0/lib/ruby/gems/shared/gems/power_assert-1.1.1/Gemfile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/power_assert-1.1.1/power_assert.gemspec
jruby-9.2.1.0/lib/ruby/gems/shared/gems/power_assert-1.1.1/Rakefile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/power_assert-1.1.1/COPYING
jruby-9.2.1.0/lib/ruby/gems/shared/gems/power_assert-1.1.1/.travis.yml
jruby-9.2.1.0/lib/ruby/gems/shared/gems/power_assert-1.1.1/README.rdoc
jruby-9.2.1.0/lib/ruby/gems/shared/gems/power_assert-1.1.1/LEGAL
jruby-9.2.1.0/lib/ruby/gems/shared/gems/did_you_mean-1.2.0/LICENSE.txt
jruby-9.2.1.0/lib/ruby/gems/shared/gems/did_you_mean-1.2.0/.ruby-version
jruby-9.2.1.0/lib/ruby/gems/shared/gems/did_you_mean-1.2.0/Gemfile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/did_you_mean-1.2.0/Rakefile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/did_you_mean-1.2.0/did_you_mean.gemspec
jruby-9.2.1.0/lib/ruby/gems/shared/gems/did_you_mean-1.2.0/README.md
jruby-9.2.1.0/lib/ruby/gems/shared/gems/did_you_mean-1.2.0/.travis.yml
jruby-9.2.1.0/lib/ruby/gems/shared/gems/did_you_mean-1.2.0/CHANGELOG.md
jruby-9.2.1.0/lib/ruby/gems/shared/gems/xmlrpc-0.3.0/LICENSE.txt
jruby-9.2.1.0/lib/ruby/gems/shared/gems/xmlrpc-0.3.0/Gemfile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/xmlrpc-0.3.0/Rakefile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/xmlrpc-0.3.0/xmlrpc.gemspec
jruby-9.2.1.0/lib/ruby/gems/shared/gems/xmlrpc-0.3.0/README.md
jruby-9.2.1.0/lib/ruby/gems/shared/gems/xmlrpc-0.3.0/.travis.yml
jruby-9.2.1.0/lib/ruby/gems/shared/gems/test-unit-3.2.7/PSFL
jruby-9.2.1.0/lib/ruby/gems/shared/gems/test-unit-3.2.7/GPL
jruby-9.2.1.0/lib/ruby/gems/shared/gems/test-unit-3.2.7/Rakefile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/test-unit-3.2.7/README.md
jruby-9.2.1.0/lib/ruby/gems/shared/gems/test-unit-3.2.7/LGPL
jruby-9.2.1.0/lib/ruby/gems/shared/gems/test-unit-3.2.7/COPYING
jruby-9.2.1.0/lib/ruby/gems/shared/gems/minitest-5.10.3/.autotest
jruby-9.2.1.0/lib/ruby/gems/shared/gems/minitest-5.10.3/Manifest.txt
jruby-9.2.1.0/lib/ruby/gems/shared/gems/minitest-5.10.3/History.rdoc
jruby-9.2.1.0/lib/ruby/gems/shared/gems/minitest-5.10.3/design_rationale.rb
jruby-9.2.1.0/lib/ruby/gems/shared/gems/minitest-5.10.3/Rakefile
jruby-9.2.1.0/lib/ruby/gems/shared/gems/minitest-5.10.3/README.rdoc

jruby -S rake results in:

LoadError: no such file to load -- /usr/local/jruby/lib/ruby/gems/shared/gems/rake-12.3.0/exe/rake
    load at org/jruby/RubyKernel.java:1000
  <main> at /usr/local/jruby/bin/rake:23

enebo added a commit that referenced this issue Nov 7, 2018

An attempt at fixing #5420.
More or less all default and installed gems will completely include themselves
into stdlib artifact which in turn will make them available when making the
jruby-dist package.

What makes me uncertain that this is right is the previous code went through
some pains to not include everything.  I am guessing there is something we don't
want and I am now including it?

Second part of this was unneeded but I removed the ImportedGem class and just
had both gem types use a nested array of arrays leveraging block destructuring.

@enebo enebo added this to the JRuby 9.2.2.0 milestone Nov 7, 2018

enebo added a commit that referenced this issue Nov 7, 2018

@enebo enebo closed this Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.