Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executors are not shut down during tearDown #5514

Closed
headius opened this Issue Dec 13, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@headius
Copy link
Member

headius commented Dec 13, 2018

We have a few executors that are not being shut down when the Ruby runtime is shutdown via the tearDown method:

  • JITCompiler has an executor for JIT threads.
  • There's a global ExecutorService used within native descriptor select operations (SelectExecutor and SelectBlob).
  • Fibers are executed in their own executor.

All three should be shut down.

Tweet and blog post that brought this to my attention: https://twitter.com/rmannibucau/status/1073163621952237568

I could have sworn someone reported this before and we fixed it, but perhaps I'm thinking of #3313, fixed in 9.2.1.

@headius headius added this to the JRuby 9.2.6.0 milestone Dec 13, 2018

@headius headius closed this in 5b24aa9 Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.