Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new grapheme cluster scheme in c code #5542

Closed
lopex opened this Issue Dec 28, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@lopex
Copy link
Member

lopex commented Dec 28, 2018

Since some time MRI diverged from onigmo wrt grapheme cluster logic, most of it is backwards now since how cons lists work on AST's.
The new scheme introduced in https://github.com/ruby/ruby/blob/trunk/regparse.c#L5823 is mostly related to how MRI gets of the leaks in how c works.
I propose to mimic the MRI implementation (even though it's main purpose relies on memory leak prevention) since it's current scheme inverses the logic in grapheme cluster regexp grammar and makes it easy to follow unicode definition.

@lopex

This comment has been minimized.

Copy link
Member Author

lopex commented Mar 5, 2019

@lopex lopex closed this Mar 5, 2019

@enebo enebo added this to the JRuby 9.2.7.0 milestone Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.