Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc with no arguments does not pick up current block #5596

Closed
enebo opened this Issue Feb 6, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@enebo
Copy link
Member

commented Feb 6, 2019

This is the base problem of #5595. Simple one-liner:

jruby -e 'def add_filter(p = proc); p.call(:lol); end; add_filter { |e| p e }'
@enebo

This comment has been minimized.

Copy link
Member Author

commented Feb 6, 2019

I have a simple fix for this...

@enebo enebo closed this in f77225d Feb 6, 2019

@enebo enebo added this to the JRuby 9.2.6.0 milestone Feb 6, 2019

enebo added a commit that referenced this issue Feb 7, 2019

Revert "Fix #5596. proc() now needs to read frame when not supplied a…
… block"

I had forgotten we explicitly decided to not support this.

This reverts commit f77225d.

kares added a commit to kares/jruby that referenced this issue Feb 9, 2019

Merge branch 'master' into ruby-2.6
* master: (73 commits)
  [ci] Travis: Drop unused setting sudo: false (jruby#5593)
  replace otto.takari with mavengem wagon (jruby#5600)
  Fixes jruby#5597. "Useless" warnings have file as "null".
  Add --record to enable a full-run Java Flight Recorder recording.
  Use stack walking API to acquire single element.
  USe &p instead of p = proc
  Revert "Fix jruby#5596. proc() now needs to read frame when not supplied a block"
  Fix jruby#5596. proc() now needs to read frame when not supplied a block
  Fix bad access of Runtime.getAvailableProcessors.
  Use pooled UTF-8 character decoders when possible.
  Use all processes reporte by JVM to speed up this suite.
  Disable the timing-out tests so they don't interfere with build.
  Try to set allowed failures again.
  Bad test? Actually use a lambda block for should_not.
  Allow tests depending on takari.io to fail for now.
  ENEBO
  Revert "Close any open selectors when tearing down a runtime."
  Time, DateTime: fix isTzRelative book keeping
  [test] remove passing psych tags
  Time: minimal fix for Rails Time.change() problem
  ...

kares added a commit to kares/jruby that referenced this issue Feb 9, 2019

Merge branch 'master' into ruby-2.6
* master: (73 commits)
  [ci] Travis: Drop unused setting sudo: false (jruby#5593)
  replace otto.takari with mavengem wagon (jruby#5600)
  Fixes jruby#5597. "Useless" warnings have file as "null".
  Add --record to enable a full-run Java Flight Recorder recording.
  Use stack walking API to acquire single element.
  USe &p instead of p = proc
  Revert "Fix jruby#5596. proc() now needs to read frame when not supplied a block"
  Fix jruby#5596. proc() now needs to read frame when not supplied a block
  Fix bad access of Runtime.getAvailableProcessors.
  Use pooled UTF-8 character decoders when possible.
  Use all processes reporte by JVM to speed up this suite.
  Disable the timing-out tests so they don't interfere with build.
  Try to set allowed failures again.
  Bad test? Actually use a lambda block for should_not.
  Allow tests depending on takari.io to fail for now.
  ENEBO
  Revert "Close any open selectors when tearing down a runtime."
  Time, DateTime: fix isTzRelative book keeping
  [test] remove passing psych tags
  Time: minimal fix for Rails Time.change() problem
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.