Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fiber/enumerator threads with info about creation #5670

Closed
headius opened this issue Mar 29, 2019 · 0 comments · Fixed by #5679
Closed

Update fiber/enumerator threads with info about creation #5670

headius opened this issue Mar 29, 2019 · 0 comments · Fixed by #5679
Milestone
JRuby 9.2.7.0

Comments

@headius
Copy link
Member

headius commented Mar 29, 2019

Currently all fiber threads end up with a name something like "Ruby-Fiber-15" because we pool those thread objects and reuse them. However, this does not provide very good information about where or why the fiber thread was enlisted.

We could setName on those threads to update the name to something that reflects the origins of the fiber or enumerator using the given fiber thread, which would make it easier to debug when there's a leak or some other issue with those coroutine threads.
headius added a commit to headius/jruby that referenced this issue Apr 6, 2019
@headius
Provide better thread name for enumerator/fiber workers.
36bd6cf 
This patch sets the name of the threads used to drive fibers (or
the similar Enumerator#next coroutines) in order to more easily
audit and debug those threads. Relates to jruby#5671 and fixes jruby#5670.
@headius headius mentioned this issue Apr 6, 2019
Merged
@enebo enebo added this to the JRuby 9.2.7.0 milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.2.7.0
Development

Successfully merging a pull request may close this issue.

Provide better thread name for enumerator/fiber workers. headius/jruby
2 participants
@headius @enebo