Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Automatic-Module-Name in all artifacts #5862

Open
headius opened this issue Sep 9, 2019 · 2 comments

Comments

@headius
Copy link
Member

commented Sep 9, 2019

For #5855 @mkristian fixed our core and complete jars to have Automatic-Module-Name, but we have nothing to test that they stay there. I think we should.

@headius headius added this to the JRuby 9.2.9.0 milestone Sep 9, 2019

@mkristian

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

@headius any idea how to test ? look into manifest and verify entry is there ?

@headius

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

@mkristian I thought we could use the jdeps command to confirm that the artifacts have the expected module name, but it doesn't seem to reflect Automatic-Module-Name:

[] ~/projects/jruby $ jdeps ~/.rvm/rubies/jruby-9.2.8.0/lib/jruby.jar 
jruby.jar -> java.base
jruby.jar -> java.compiler
jruby.jar -> java.desktop
...

Checking the manifest would be good enough for now, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.