Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.2.10.0] bogus revision regression #6090

Closed
ahorek opened this issue Feb 20, 2020 · 4 comments
Closed

[9.2.10.0] bogus revision regression #6090

ahorek opened this issue Feb 20, 2020 · 4 comments

Comments

@ahorek
Copy link
Contributor

@ahorek ahorek commented Feb 20, 2020

simply run jruby -v

Environment Information
jruby 9.2.10.0 (2.5.7) 2020-02-18 fffffff Java HotSpot(TM) 64-Bit Server VM 11.0.2+9-LTS on 11.0.2+9-LTS +jit [linux-x86_64]

Expected Behavior
jruby 9.2.9.0 (2.5.7) 2019-10-30 458ad3e Java HotSpot(TM) 64-Bit Server VM 11.0.2+9-LTS on 11.0.2+9-LTS +jit [linux-x86_64]

Actual Behavior
jruby 9.2.10.0 (2.5.7) 2020-02-18 fffffff Java HotSpot(TM) 64-Bit Server VM 11.0.2+9-LTS on 11.0.2+9-LTS +jit [linux-x86_64]

fffffff is a fake value

my first guess, it has something to do with #5996 ?

@headius
Copy link
Member

@headius headius commented Feb 20, 2020

Huh yeah I noticed that myself yesterday and thought I was doing something wrong. That hash should not be passing through RubyGems at all so I suspect a build change has broken how we get the git hash installed in our code. I'll get it fixed.

@headius
Copy link
Member

@headius headius commented Feb 20, 2020

Bisected to 2e604ad which attempted to remove some local build paths from the built artifacts.

I have a change that switches the phase this runs in from initialize to prepare-resources, and that seems to fix it. I'll push that change now.

@mkristian Anything wrong with this change you can see?

diff --git a/core/pom.rb b/core/pom.rb
index f38c197b43..549d4499b0 100644
--- a/core/pom.rb
+++ b/core/pom.rb
@@ -260,7 +260,7 @@ project 'JRuby Core' do
   end
 
   plugin :resources do
-    execute_goals('copy-resources', phase: :initialize,
+    execute_goals('copy-resources', phase: 'process-resources',
                   outputDirectory: '${basedir}',
                   resources: [
                     {

@headius headius added this to the JRuby 9.2.11.0 milestone Feb 20, 2020
@mkristian
Copy link
Member

@mkristian mkristian commented Feb 20, 2020

headius added a commit that referenced this issue Feb 20, 2020
@headius
Copy link
Member

@headius headius commented Feb 20, 2020

@mkristian Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants