Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date._strptime raises Java exception on invalid argument #6428

Closed
kares opened this issue Oct 7, 2020 · 0 comments · Fixed by #6429
Closed

Date._strptime raises Java exception on invalid argument #6428

kares opened this issue Oct 7, 2020 · 0 comments · Fixed by #6429
Labels
beginner core
Milestone
JRuby 9.2.14.0

Comments

@kares
Copy link
Member

kares commented Oct 7, 2020

... while it should properly raise a Ruby TypeError, such as with MRI:

ruby -rtime -e "Time.strptime(0, '%Y-%m-%d')"

time.rb:432:in `_strptime': no implicit conversion of Integer into String (TypeError)

ruby -rtime -e "Time.strptime(nil, '%Y-%m-%d')"

time.rb:432:in `_strptime': no implicit conversion of nil into String (TypeError)

JRuby (9.2.13.0) ends up with:

        4: from org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:203)
        3: from org.jruby.ext.date.RubyDate$INVOKER$s$_strptime.call(RubyDate$INVOKER$s$_strptime.gen)
        2: from org.jruby.ext.date.RubyDate._strptime(RubyDate.java:1685)
        1: from org.jruby.ext.date.RubyDate.parse(RubyDate.java:1691)
Java::JavaLang::ClassCastException (org.jruby.RubyNil cannot be cast to org.jruby.RubyString)
MariuszCwikla pushed a commit to MariuszCwikla/jruby that referenced this issue Oct 7, 2020
Fixes jruby#6428: Date._strptime raises Java exception on invalid arg…
d16392f 
…ument
@MariuszCwikla MariuszCwikla mentioned this issue Oct 7, 2020
Merged
MariuszCwikla added a commit to MariuszCwikla/jruby that referenced this issue Oct 7, 2020
@MariuszCwikla
Fixes jruby#6428: Date._strptime raises Java exception on invalid arg…
0b26210 
…ument
kares pushed a commit that referenced this issue Oct 7, 2020
@MariuszCwikla
[fix] Date._strptime raises Java exception on invalid argument (#6429)
7e0de64 
Fixes #6428
@kares kares added this to the JRuby 9.3.0.0 milestone Oct 7, 2020
kares pushed a commit to kares/jruby that referenced this issue Oct 9, 2020
@MariuszCwikla @kares
[fix] Date._strptime raises Java exception on invalid argument (jruby…
e45a9ad 
…#6429)

Fixes jruby#6428
@kares kares modified the milestones: JRuby 9.3.0.0, JRuby 9.2.14.0 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner core
Projects
None yet
Milestone
JRuby 9.2.14.0
Development

Successfully merging a pull request may close this issue.

Fixes #6428: Date._strptime raises Java exception on invalid argument MariuszCwikla/jruby
1 participant
@kares