Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled did_you_mean gem v1.2.0 has a CC NonCommercial license in included file #6471

Closed
colinsurprenant opened this issue Nov 19, 2020 · 4 comments · Fixed by #6473
Closed

Comments

@colinsurprenant
Copy link
Contributor

Bundled gem did_you_mean v1.2.0 has a Creative Commons Attribution-NonCommercial-ShareAlike 3.0 license on an included file.

Per ruby/did_you_mean#105 starting in v1.2.1 the whole evaluation/ is now excluded from the gem which now ships without non-production code that has a non-commercial license.

I am leaving the trivial code-change to the team as I am unsure if a version more recent than v1.2.1 would be preferred here.

@headius
Copy link
Member

headius commented Nov 20, 2020

I don't see any reason we can't upgrade this in 9.3, and possibly in 9.2.14 if the gem is still compatible with Ruby 2.5.

@enebo Any concerns about updating did_you_mean for 9.2.14?

@headius headius added this to the JRuby 9.2.14.0 milestone Nov 20, 2020
@headius
Copy link
Member

headius commented Nov 20, 2020

The latest is 1.4.0. We could either go to that and be current or just bump to 1.2.1 to get the CC stuff out of there. Bumping to 1.2.1 would clearly be the least impact.

headius added a commit to headius/jruby that referenced this issue Nov 20, 2020
Prior to 1.2.1 the did_you_mean gem included yaml content licensed
under CC BY-NC-SA 3.0 which prohibits commercial use. This has
been remedied in 1.2.1 and this PR updates our preinstalled
version.

See jruby#6471.
@headius headius linked a pull request Nov 20, 2020 that will close this issue
@colinsurprenant
Copy link
Contributor Author

Perfect, thanks @headius!

@headius
Copy link
Member

headius commented Dec 2, 2020

Fixed by #6473.

@headius headius closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants