Ant integration causes exception trace on failed build #653

Closed
headius opened this Issue Apr 24, 2013 · 0 comments

Projects

None yet

1 participant

@headius
JRuby Team member

When calling an ant task from e.g. a rake build, if the ant task fails it will bubble out an org.apache.tools.ant.ExitStatusException that we proceed to log in Main.java. This probably started showing up when we stopped wrapping Java exceptions in NativeException, which allows it to bubble out through our RaiseException handling.

I'm not sure where, but somewhere in ant integration we need to capture ExitStatusException and produce an appropriate Rake error, rather than letting it bubble out.

@headius headius added a commit that closed this issue Apr 24, 2013
@headius headius Catch all exceptions when running ant subtask, to avoid bubbling.
This should fix #653. We may catch too much here, but it seems
the intent of the rescue block was to capture most exceptions. It
also would have caught the ant ExitStatusException as a
NativeException before, but that stopped working after we stopped
wrapping Java exceptions. The fix should catch it properly now.
ca30066
@headius headius closed this in ca30066 Apr 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment