Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Ruby 2.0 Compatibility - NET:HTTP #659

Closed
nixpulvis opened this Issue · 9 comments

3 participants

Nathan Lilienthal Charles Oliver Nutter Uwe Kubosch
Nathan Lilienthal

Ruby 2.0 changed Net::HTTPMultipleChoice to the correct Net::HTTPMultipleChoices.

See my comment on this issue

JRuby 1.7.3 with compat.version=2.0 set, does not reflect this change.

Charles Oliver Nutter
Owner

Ok...so we should get this from our copy of stdlib, but since 2.0 mode isn't "officially" supported yet we don't ship that with some forms of release.

How did you get/build/install JRuby?

Nathan Lilienthal

ruby-build

Charles Oliver Nutter
Owner

Can you check if there's a lib/ruby/2.0 in the installed JRuby? I'm guessing we don't include it in our source and binary archives, so ruby-build doesn't have it.

Charles Oliver Nutter
Owner

Oh, and you could also try pulling and building JRuby master to see if it works. It occurs to me now that we didn't add 2.0 stdlib (and a bunch of other stuff) until after the JRuby 1.7.3 release.

Charles Oliver Nutter
Owner

Ok, I did test this on master myself, and it works ok. I think the only issue is that there's no 2.0 stdlib in the release you're running.

@enebo With more people starting to play with 2.0 mode, perhaps we should consider pulling in 2.0 stdlib for JRuby 1.7.4?

Charles Oliver Nutter headius closed this
Uwe Kubosch
Collaborator

:+1: on adding the 2.0 stdlib. We would very much like to start using Ruby 2.0 mode, and I would guess the 2.0 stdlib is required to make it work properly.

Charles Oliver Nutter
Owner

We have been reluctant to officially support 2.0 mode since we can't (or don't want to) try to support Module#prepend, which is an official 2.0 feature. But I could be convinced to include stdlib if folks are comfortable with that limitation.

Charles Oliver Nutter
Owner

FWIW, 2.0 stdlib will now be part of dist artifacts. It adds size, but @enebo and I figured it's worth it to avoid folks filing issues due to 1.9.3 stdlib in 2.0 mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.