Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.0 Compatibility - NET:HTTP #659

Closed
nixpulvis opened this Issue Apr 26, 2013 · 9 comments

Comments

Projects
None yet
3 participants
@nixpulvis
Copy link

nixpulvis commented Apr 26, 2013

Ruby 2.0 changed Net::HTTPMultipleChoice to the correct Net::HTTPMultipleChoices.

See my comment on this issue

JRuby 1.7.3 with compat.version=2.0 set, does not reflect this change.

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 26, 2013

Ok...so we should get this from our copy of stdlib, but since 2.0 mode isn't "officially" supported yet we don't ship that with some forms of release.

How did you get/build/install JRuby?

@nixpulvis

This comment has been minimized.

Copy link
Author

nixpulvis commented Apr 26, 2013

ruby-build

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 26, 2013

Can you check if there's a lib/ruby/2.0 in the installed JRuby? I'm guessing we don't include it in our source and binary archives, so ruby-build doesn't have it.

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 26, 2013

Oh, and you could also try pulling and building JRuby master to see if it works. It occurs to me now that we didn't add 2.0 stdlib (and a bunch of other stuff) until after the JRuby 1.7.3 release.

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 27, 2013

Ok, I did test this on master myself, and it works ok. I think the only issue is that there's no 2.0 stdlib in the release you're running.

@enebo With more people starting to play with 2.0 mode, perhaps we should consider pulling in 2.0 stdlib for JRuby 1.7.4?

@headius headius closed this Apr 27, 2013

@donv

This comment has been minimized.

Copy link
Member

donv commented Apr 28, 2013

👍 on adding the 2.0 stdlib. We would very much like to start using Ruby 2.0 mode, and I would guess the 2.0 stdlib is required to make it work properly.

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 28, 2013

We have been reluctant to officially support 2.0 mode since we can't (or don't want to) try to support Module#prepend, which is an official 2.0 feature. But I could be convinced to include stdlib if folks are comfortable with that limitation.

@headius

This comment has been minimized.

Copy link
Member

headius commented May 1, 2013

FWIW, 2.0 stdlib will now be part of dist artifacts. It adds size, but @enebo and I figured it's worth it to avoid folks filing issues due to 1.9.3 stdlib in 2.0 mode.

@nixpulvis

This comment has been minimized.

Copy link
Author

nixpulvis commented May 1, 2013

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.