Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jruby-openssl gem breaks PKCS5 #719

Closed
headius opened this issue May 8, 2013 · 3 comments
Closed

jruby-openssl gem breaks PKCS5 #719

headius opened this issue May 8, 2013 · 3 comments

Comments

@headius
Copy link
Member

@headius headius commented May 8, 2013

JRuby uses krypt to provide pkcs5, via require 'krypt/ossl' in lib/ruby/shared/openssl.rb. However, the jruby-openssl.rb file we load from the gem does not have this line, and so OpenSSL::PKCS5 is never defined.

A workaround is to require krypt/ossl yourself.

Proper gemification of jruby-openssl would fix this, as would simply adding the require to the gem's jruby-openssl.rb file, but we also need to ensure the depdency comes along for pre-1.7 JRuby (and we should probably be treating krypt as a default gem anyway).

Unsure of the status of gemification of krypt. Can you comment, @emboss?

@emboss
Copy link

@emboss emboss commented May 9, 2013

@headius: There is a gem version published that should be equal to the version you included in JRuby. The "krypt-core" gem is also published with separate JRuby and C-based versions, so that it should work out of the box that if you do "gem install krypt" it will automatically pull in the JRuby-specific sub gems if you're on JRuby.

Would that work for you? Let me know if you want me to change anything!

@kares
Copy link
Member

@kares kares commented Mar 20, 2015

this is now obsolete with jruby-openssl 0.9.6 and since JRuby 1.7.20 will bundle 0.9.6 closing as resolved

@hathawad
Copy link

@hathawad hathawad commented Jun 16, 2015

Just for clarity, if you are running into this issue w/ Rails, you need to add the krypt gem to your GEMFILE as the krypt jars are no longer part of the JRuby install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants