2.0: Missing File::FNM_EXTGLOB and whatever uses it

[enebo]

2.0 defined File::FNM_EXTGLOB and it must use it somewhere. We should define this and hook up da bits.

[rkh]

The functionality should exist somewhere already, as this is behavior has been previously implemented in Dir.glob already, but not in File.fnmatch.

It basically means that {a,b} matches both a and b.

So File.fnmatch is using it. Interestingly, until I submitted a patch a few days back, this wasn't documented in Ruby at all and I only learned about it by actually reading the MRI source.

[rkh]

Seems like ruby-doc.org has already been updated with my patch: http://www.ruby-doc.org/core-2.0/File.html#method-c-fnmatch

[headius]

This logic is indeed new, implemented by ruby_brace_expand called from fnmatch. We'll need to port it to support the new behavior.

[jc00ke]

This is how I managed it in rubinius/rubinius@d95487c

[jc00ke]

Actually, I'd like to see if I can add this to JRuby too. It'd be my first commit.

[rkh]

Do it! :)

On Thu, Nov 6, 2014 at 8:31 AM, Jesse Cooke notifications@github.com
wrote:

Actually, I'd like to see if I can add this to JRuby too. It'd be my first
commit.

—
Reply to this email directly or view it on GitHub
#721 (comment).

[bbrowning]

I just wanted to add a note that this prevents Rails 4.1 apps from running under JRuby 9.0.0.0, since Rails now uses File::FNM_EXTGLOB when locating template paths under 2.2.0+.