Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rake spec:compiler failing since ba4df82 #746

Closed
atambo opened this Issue May 19, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@atambo
Copy link
Member

atambo commented May 19, 2013

rake spec:compiler has been failing since commit ba4df82. cc @headius

The tests all seem to pass but rake still marks the task as failed:

./bin/jruby -S rake spec:compiler                                                                                                                                                   ☺
/Users/tambellini/repos/jruby/bin/jruby --1.8 -S rspec spec/compiler/general_spec.rb spec/compiler/rubyscript_spec.rb spec/compiler/skinnymethodadapter_spec.rb
.........................................

Finished in 1.4 seconds
42 examples, 0 failures

rake aborted!
/Users/tambellini/repos/jruby/bin/jruby --1.8 -S rspec spec/compiler/general_spec.rb spec/compiler/rubyscript_spec.rb spec/compiler/skinnymethodadapter_spec.rb failed
org/jruby/RubyBasicObject.java:1505:in `__send__'
org/jruby/RubyKernel.java:2213:in `send'
org/jruby/RubyProc.java:255:in `call'
org/jruby/RubyArray.java:1617:in `each'
org/jruby/RubyArray.java:1617:in `each'
org/jruby/RubyArray.java:1617:in `each'
org/jruby/RubyKernel.java:1073:in `load'
Tasks: TOP => spec:compiler => spec:compiler:int
(See full trace by running task with --trace)
@headius

This comment has been minimized.

Copy link
Member

headius commented May 21, 2013

Weird...I'll look into it.

@headius

This comment has been minimized.

Copy link
Member

headius commented May 21, 2013

Ok...I suspect the problem is that $! isn't getting cleared somewhere after that change. It's supposed to be, but by fixing the reported issue I may have opened up a bug already there.

I did try to fix some code that failed to clear $!, but perhaps I missed something.

@headius

This comment has been minimized.

Copy link
Member

headius commented May 21, 2013

Ok one of the specs I added was bad, and it left an exception in flight but did a forced return, causing specs to either appear to pass or to be terminated prematurely. Removing it.

@headius

This comment has been minimized.

Copy link
Member

headius commented May 21, 2013

Fixed by 171a797.

@headius headius closed this May 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.