Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a convenient way to incorporate the latest tzdata #837

Closed
BanzaiMan opened this Issue Jul 1, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@BanzaiMan
Copy link
Member

BanzaiMan commented Jul 1, 2013

27c42cc removed tzdata-related ant tasks without maven equivalents.

  1. update-constants should generate Constants.java such that @tzdata-version@ is correctly updated
  2. There should be a way to download the lastest data from ftp.iana.org, compile data (see joda-time's ant target; 27c42cc#L0L955), and update joda-time-*.jar.
@headius

This comment has been minimized.

Copy link
Member

headius commented Jul 1, 2013

Talked a bit on IRC about this...

I think the joda-timezones package @mkristian set up should be doing this ok. It's located in maven/joda-timezones. mvn install will install a jar locally for the latest tzdata. Updating just involves updating the pom to the tzdata version.

We will want to get this deployed to central so it can be used from the build, and whenever we update tzdata we'll push a new jar to central.

@BanzaiMan

This comment has been minimized.

Copy link
Member Author

BanzaiMan commented Jul 1, 2013

The current (as of 6170c5e) maven goal does not work. For testing, do:

$ TZ=Asia/Gaza jruby -ve 'puts Time.local(2008,3,29)'
jruby 1.7.5.dev (1.9.3p392) 2013-07-01 6170c5e on Java HotSpot(TM) 64-Bit Server VM 1.7.0_21-b12 [darwin-x86_64]
2008-03-29 00:00:00 +0200

With the correct 2013c version of tzdata, the offset should be +0300. (At 678a355, ant clean update-tzdata jar produces the desired result.)

@headius

This comment has been minimized.

Copy link
Member

headius commented Jul 1, 2013

I think this is fixed in db1b1bb. Let me know if it's still not working.

  • I confirmed it's pulling our tzdata instead of joda's:

$ TZ=Asia/Gaza jruby -e 'puts Time.local(2008,3,29)'
2008-03-29 00:00:00 +0300

  • I confirmed that updating joda-timezone's pom, installing it, updating out pom, and rebuilding picks up new tzdata.

@ghost ghost assigned headius Jul 1, 2013

@BanzaiMan

This comment has been minimized.

Copy link
Member Author

BanzaiMan commented Jul 1, 2013

Fixed as of c8cf579.

@BanzaiMan BanzaiMan closed this Jul 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.