jruby --properties generates confusing comments in .jrubyrc #949

Closed
javallone opened this Issue Aug 9, 2013 · 2 comments

2 participants

@javallone

When using the --properties flag to generate a base .jrubyrc, several properties default to null. This leads to lines like ir.passes=null in the file.

This seems to set the property to the string "null" instead of a null object which leads to jruby failing to run (at least in the case of ir.passes).

Commenting the offending lines seems to resolve the problem, but the --properties flag should probably generate those null properties as commented lines to being with.

@BanzaiMan
JRuby Team member

The output has these offending lines commented out.

@BanzaiMan BanzaiMan was assigned Aug 15, 2013
@BanzaiMan BanzaiMan added a commit that closed this issue Aug 15, 2013
@BanzaiMan BanzaiMan Change `--properties` output for null default opts [skip ci]
Fixes #949

For options whose default is `null`, it is confusing to print out the
string `null`, since it is not a likely value that the user can use.
While the message makes it clear that the value will be interpreted as a
String, it is a good idea to leave it blank instead, so that the user
can fill it themselves.
bab765f
@BanzaiMan BanzaiMan closed this in bab765f Aug 15, 2013
@BanzaiMan
JRuby Team member

The produced output is valid, since they are comment out. Furthermore, they are clearly marked to indicate how they will be interpreted, and the default is null.

Having said that, I tweaked in bab765f so that the value is not printed in the right side of the assignment to reduce potential confusion.

@rajcybage rajcybage pushed a commit that referenced this issue Aug 21, 2013
@BanzaiMan BanzaiMan Change `--properties` output for null default opts [skip ci]
Fixes #949

For options whose default is `null`, it is confusing to print out the
string `null`, since it is not a likely value that the user can use.
While the message makes it clear that the value will be interpreted as a
String, it is a good idea to leave it blank instead, so that the user
can fill it themselves.
e90158c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment