Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jruby --properties generates confusing comments in .jrubyrc #949

Closed
javallone opened this issue Aug 9, 2013 · 2 comments
Closed

jruby --properties generates confusing comments in .jrubyrc #949

javallone opened this issue Aug 9, 2013 · 2 comments
Assignees
Milestone

Comments

@javallone
Copy link

@javallone javallone commented Aug 9, 2013

When using the --properties flag to generate a base .jrubyrc, several properties default to null. This leads to lines like ir.passes=null in the file.

This seems to set the property to the string "null" instead of a null object which leads to jruby failing to run (at least in the case of ir.passes).

Commenting the offending lines seems to resolve the problem, but the --properties flag should probably generate those null properties as commented lines to being with.

@BanzaiMan
Copy link
Member

@BanzaiMan BanzaiMan commented Aug 9, 2013

The output has these offending lines commented out.

@ghost ghost assigned BanzaiMan Aug 15, 2013
@BanzaiMan BanzaiMan closed this in bab765f Aug 15, 2013
@BanzaiMan
Copy link
Member

@BanzaiMan BanzaiMan commented Aug 15, 2013

The produced output is valid, since they are comment out. Furthermore, they are clearly marked to indicate how they will be interpreted, and the default is null.

Having said that, I tweaked in bab765f so that the value is not printed in the right side of the assignment to reduce potential confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants