Skip to content

ThreadGroup#enclose does not guard against thread addition #950

Closed
halorgium opened this Issue Aug 9, 2013 · 2 comments

2 participants

@halorgium

The code:

tg = ThreadGroup.new
tg.enclose
t = Thread.new { sleep }
tg.add(t)

should raise ThreadError: can't move to the enclosed thread group.

There is no such guard presently.

@BanzaiMan BanzaiMan added a commit that closed this issue Sep 2, 2013
@BanzaiMan BanzaiMan Check 'frozen' and 'enclosed' before moving Thread
When moving a Thread from one ThreadGroup to another, both
the source and the target ThreadGroup must not be frozen or enclosed.

This fixes #950.
b4cedc0
@BanzaiMan BanzaiMan closed this in b4cedc0 Sep 2, 2013
@BanzaiMan
JRuby Team member

@halorgium We need specs for these. They should check frozen and enclosed for both the source and the destination ThreadGroups.

@halorgium

@BanzaiMan could you reopen this one or file a new issue on RubySpec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.