Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jruby-jars gem] lib/jruby-jars.rb not same as source, and fails to load "jruby-jars/version" #959

Closed
donv opened this issue Aug 18, 2013 · 3 comments
Assignees
Milestone

Comments

@donv
Copy link
Member

@donv donv commented Aug 18, 2013

Hi!

Looking inside the new jruby-jars gem, the content of lib/jruby-jars.rb is not the same in the gem as in the source repository.

The version distributed in the gem is updated with the new jar names, but does not require jruby-jars/version.

This is a major api change I think we should reverse. JRubyJars::VERSION should be available after the gem has been loaded.

@mkristian
Copy link
Member

@mkristian mkristian commented Aug 18, 2013

added the VERSION back in commit 4932a84

let me know if I missed something else ;)

@ghost ghost assigned mkristian Aug 21, 2013
@BanzaiMan
Copy link
Member

@BanzaiMan BanzaiMan commented Aug 21, 2013

@donv Could you verify this?

@donv
Copy link
Member Author

@donv donv commented Sep 20, 2013

Hi @mkristian && @BanzaiMan !

This looks OK now. Closing.

@donv donv closed this Sep 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants