Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package jay/yydebug should only be in jruby-core not jruby-stdlib #972

Closed
donv opened this issue Aug 25, 2013 · 2 comments
Closed

Package jay/yydebug should only be in jruby-core not jruby-stdlib #972

donv opened this issue Aug 25, 2013 · 2 comments
Milestone

Comments

@donv
Copy link
Member

@donv donv commented Aug 25, 2013

The jay/yydebug package should not be in both jars. This adds unnecessary size to the distro, and breaks Ruboto when it tries to package since each class is only allowed in one jar at package time.

@mkristian
Copy link
Member

@mkristian mkristian commented Aug 25, 2013

I need more info - is it from a download (the location would be very helpful) or build from source but there I see

[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ jruby-stdlib ---
[INFO] org.jruby:jruby-stdlib:jar:1.7.5.dev
[INFO] +- org.jruby:readline:jar:1.0-SNAPSHOT:provided
[INFO] +- org.jruby:openssl:jar:0.8.9-SNAPSHOT:provided
[INFO] +- org.bouncycastle:bcpkix-jdk15on:jar:1.47:compile
[INFO] \- org.bouncycastle:bcprov-jdk15on:jar:1.47:compile

I also check the jruby-jars gem which does also include only a META-INF directory without any java classes.

mkristian added a commit that referenced this issue Aug 25, 2013
@donv
Copy link
Member Author

@donv donv commented Aug 25, 2013

The changes look good! Thanks!

@donv donv closed this Aug 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants