Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin fixing osgi metadata for maven build #1020

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@ajuckel
Copy link
Contributor

ajuckel commented Sep 17, 2013

Initial work toward re-enabling OSGi metadata generation in the new maven build.

ajuckel added some commits Sep 9, 2013

Fix up osgi test and bundle metadata generation
The bnd configuration wasn't brought over from the old ant build
into the new maven build process.  This is a first (perhaps clumsy)
attempt at getting working metadata added.  At least enough to
satisfy the jruby-osgi-test tests.  Further investigation is needed
to verify:

  1) Nothing is included in the bundle that shouldn't be shipped
  2) The bundle adequately expresses it's required/optional packages
@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Sep 17, 2013

Do we need Eclipse metadata?

@ghost ghost assigned mkristian Sep 17, 2013

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Sep 17, 2013

@mkristian Please take a look.

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Sep 17, 2013

I moved the osgi-test suite to be an integration test on maven/jruby-complete (/src/it/osgi-test) and as such it did pass. the actual osgi instrcutions are in the main pom.xml which get shared between: jruby-complete, jruby-stdlib, jruby-core and jruby main artifact (/maven/jruby)

I did not add an integration test to jruby main artifact yet since I was not sure what kind of 'box" I am opening here.

maybe you could leave out those eclipse config files since they are not part of the actual patch.

@ajuckel

This comment has been minimized.

Copy link
Contributor Author

ajuckel commented Sep 17, 2013

It seems @mkristian already did everything I was trying to accomplish in this patch, I just wasn't up to date with his recent work. Closing this request as it's unneeded. I'll test out his results instead.

@ajuckel ajuckel closed this Sep 17, 2013

mkristian added a commit that referenced this pull request Sep 19, 2013

mkristian added a commit that referenced this pull request Sep 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.