Fix compatibility wiht Bouncy Castle 1.49. #1157

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@voxik
Contributor
voxik commented Oct 24, 2013

Hi,

I am trying to update JRuby packages in Fedora and it seems that JRuby is not compatible with Bouncy Castle 1.49:

[ERROR] /builddir/build/BUILD/jruby-1.7.5/ext/openssl/src/main/java/org/jruby/ext/openssl/x509store/PEMInputOutput.java:[369,36] error: PBES2Parameters(ASN1Sequence) has private access in PBES2Parameters
[ERROR] /builddir/build/BUILD/jruby-1.7.5/ext/openssl/src/main/java/org/jruby/ext/openssl/x509store/PEMInputOutput.java:[375,89] error: cannot find symbol
[ERROR] /builddir/build/BUILD/jruby-1.7.5/ext/openssl/src/main/java/org/jruby/ext/openssl/x509store/PEMInputOutput.java:[381,49] error: cannot find symbol

I come with this patch to fix the compatibility. I would appreciate if you can accept

@mkristian
Member

I wonder if there are any tests for such functionality (that is where I dropped my patch before) ?

@voxik
Contributor
voxik commented Oct 24, 2013

Well, hard to say ... I am still far from being able to run the test suite, but I can compile this bit at least :)

@enebo
Member
enebo commented Oct 28, 2013

Are there versioned API docs? How far back do we need to go to support these newer signatures?

@headius
Member
headius commented Oct 28, 2013

I'm going to look at this and see if it passes tests.

@headius
Member
headius commented Oct 28, 2013

The code appears to merge and pass all tests just fine on JRuby master. I don't think there are objections to merging there, but since we maintain jruby-openssl and bouncy-castle gems across older JRuby impls, we may want to discuss whether to merge now or not.

@headius
Member
headius commented Oct 28, 2013

Merged into 1.7 and master.

@headius headius closed this Oct 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment